From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id ZxfaMxdNPmPFxAAAbAwnHQ (envelope-from ) for ; Thu, 06 Oct 2022 05:35:51 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id S4raMhdNPmNzUgAA9RJhRA (envelope-from ) for ; Thu, 06 Oct 2022 05:35:51 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 60F7BE0CB for ; Thu, 6 Oct 2022 05:35:51 +0200 (CEST) Received: from localhost ([::1]:43870 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ogHfq-0007Dc-2t for larch@yhetil.org; Wed, 05 Oct 2022 23:35:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45098) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ogHLH-0003Rd-9p for emacs-orgmode@gnu.org; Wed, 05 Oct 2022 23:14:36 -0400 Received: from mail-pg1-x529.google.com ([2607:f8b0:4864:20::529]:38860) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ogHL6-0007E1-89 for emacs-orgmode@gnu.org; Wed, 05 Oct 2022 23:14:34 -0400 Received: by mail-pg1-x529.google.com with SMTP id 129so713982pgc.5 for ; Wed, 05 Oct 2022 20:14:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date; bh=yJOZ6MKB1vnoo28wZrxsPAzcOFvagfGExpQz6FyRJys=; b=oyHAQgeUw+VU0fBzWoiHPs9v0pO2A0dXdoBbEcu0BjqC9bzZfQByru/7WvGwyjMmB3 G2SMgQO6ApG0+BoDwJEMEA7ZeON6kBxAc2CimIcDS7VB3BFBthFqoG3ZTEF81ao+atNU z3mG3VdLbxNrGhuk2wGTpzz9Zd9Bu+Dp1A97ed6jsO89NoSb6eRq1aHqleao0NNXRmm1 +yTnV7d5zSPtbP0sOE04Fqgf63/+K+rgAuD1GA6KpY2iLpeJPbEmFbRPG0P+NH0ZtwA8 /pzhukUvcv1zKEDX8I0/fDfGZ5mi6Dt8M+vNK5GujPI3cfpNdXPdmu+vTWWZbD0gMCA0 bTlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date; bh=yJOZ6MKB1vnoo28wZrxsPAzcOFvagfGExpQz6FyRJys=; b=xg61qYCLmgLkGtv+drTwUQs0k7CUVXbuXQ8fDaaRHXoliw2IkMARlmdtojOqHUHgPH jqXXNwKHbt/S7xvhilSEBdjzzv6KKiWjECuDww3y9eT00hjW15Yfp47NM5ofOkJU/fhj xnHb4X2no9RohxOl0rNZI6GAzViGQbaFJbywU8QxvZEShhde80/ZKKrdCWOARZEta7oS bSzfaZXcdaaQre2I+RQMZ2JckqA1+sQLcf8gv75WdN8Yhe0iEsjXU8ZBI0dwBj8Kec3a 0dg/pvS0qa9M+6rIXZZ0nbhet4yLKgytbp3GVXEBX3i6mY4M9sqxF17uiF/z5uVT7s2D Cwog== X-Gm-Message-State: ACrzQf00eGZ5A1nhv7/I0KIuKWvMWl8BHszaqly7Ulk40QyW827AJJpy h6kxoxZXDgkflm6iGH8rg/1qgN3ev3I= X-Google-Smtp-Source: AMsMyM7F46o7DLUWpZXP3vtlX9MVhzoFEz4COIb2rPJNaJvSiicFoSSJaGMI9P+wCvHA2P/pLjVigA== X-Received: by 2002:a62:b501:0:b0:557:d887:20ee with SMTP id y1-20020a62b501000000b00557d88720eemr2901374pfe.8.1665026062984; Wed, 05 Oct 2022 20:14:22 -0700 (PDT) Received: from localhost ([1.83.154.214]) by smtp.gmail.com with ESMTPSA id 135-20020a62148d000000b00540c8ed61ddsm7218992pfu.150.2022.10.05.20.14.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Oct 2022 20:14:22 -0700 (PDT) From: Ihor Radchenko To: Jonas Bernoulli Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH 1/1] Allow returning empty list from post-processing block In-Reply-To: <20221005132122.19212-2-jonas@bernoul.li> References: <874jwkwb4c.fsf@localhost> <20221005132122.19212-1-jonas@bernoul.li> <20221005132122.19212-2-jonas@bernoul.li> Date: Thu, 06 Oct 2022 11:15:14 +0800 Message-ID: <875ygx7id9.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::529; envelope-from=yantar92@gmail.com; helo=mail-pg1-x529.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1665027351; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=yJOZ6MKB1vnoo28wZrxsPAzcOFvagfGExpQz6FyRJys=; b=CBjbPlTk0gLb1VIOS7hh5a+QSd1M1M8W+h8bpRUuT2bw49AbzKeE3GwkrmOU6KBfIo6zQm COUW5w0Ogn9UATwGw4t70IlEV3e/94laWy/NOBEEB097ZkSEl8wKHDaUzSVwiVWEdPGS9+ DjU2y4ADqM9uDF8R6LxU9uB+q2z7ehlCAnc/udWpfv3PlA9D2WtvnoBs7i36qSOz6zExt0 mEabiPT7m48Mtt/7J4XzqvvpqiGbVxsu9PUHd07yEqZlYUkSA6MNKysV1w51F9jZJBaxgV 6M4ZH+DYPbgfGoJkSrGVaT3ydBdS19BFkZmnvrjPbpjWOVnT9So67+aYqWXB5A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1665027351; a=rsa-sha256; cv=none; b=Pl+KGh4r2eKx3+jqz2FkP2f8oMjczq3LXbDCqehO2x3PInX5t5wS8BgZGYmPaC6ssCnjRq VN5LVYBCRVrdq6gYhoXoAJL6sUEfmDQGDYW3kB66GpXt04tuJxaajXLhSMGToiQfHcGKu3 S0pSZqUGJsfm1H6aFu4LN+R+O5Od05evpZu119FYlBg7inJZ7krfwvtOtv5sSgaYtr0UyU XM0j8lePnNX8surxbJGun8ynO/nG3KFex9VLGvMs2dN7k6Nw2RWPYpSvBfAl5zPtqcAYDe TRP+gK0HrNWp6lR+BZvqyFhsCWxKIHkJBIBDy9roGqdygegbxluYs1GP1IxwWg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=oyHAQgeU; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.36 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=oyHAQgeU; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 60F7BE0CB X-Spam-Score: -3.36 X-Migadu-Scanner: scn1.migadu.com X-TUID: 4+iL95Pwk8yI Jonas Bernoulli writes: > * lisp/ob-ref.el (org-babel-ref-resolve): When the result an empty > list, then treat it as a list, not as the symbol nil. > * testing/lisp/test-ob.el (test-ob/return-empty-list-from-post-block): > Add new test. > * etc/ORG-NEWS (Post-processing code blocks can return an empty list): > Document change in behavior. Thanks for the patch! LGTM in general. > > +(ert-deftest test-ob/return-empty-list-from-post-block () Re: test location. Should probably be around `test-ob/elisp-in-header-arguments'. Also, I'd slightly prefer to have a more general test name like test-ob/post-header-argument. We may add more cases inside later. I have no comments wrt the code in the commit. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at