From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id wIfbBDa0omQKeQAASxT56A (envelope-from ) for ; Mon, 03 Jul 2023 13:42:46 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id uHzqAza0omSSOAAAG6o9tA (envelope-from ) for ; Mon, 03 Jul 2023 13:42:46 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A2886392A6 for ; Mon, 3 Jul 2023 13:42:45 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qGHwG-0005E7-CU; Mon, 03 Jul 2023 07:41:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qGHw4-00058I-IY for emacs-orgmode@gnu.org; Mon, 03 Jul 2023 07:41:42 -0400 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qGHw0-00054d-O3 for emacs-orgmode@gnu.org; Mon, 03 Jul 2023 07:41:38 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id AFE96240103 for ; Mon, 3 Jul 2023 13:41:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1688384493; bh=jzvGGpaDZhKaen1deOy6zROMlz3AidfuIERJdqCIR4M=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version: Content-Transfer-Encoding:From; b=pYhv2Aak3Yxrh/rp8W6OVe6iVNuFwOlfrYEhTCJ3hQJLyCKFTbqG8rB9Obsu2Zids Pl6lemjeuwi3CyDJhemM+VQxNn2qZV3okR5SYZoMi7/MYwANW11qE9fBmY/71RdC2O uS5iiG7dk8JS2Zf8QE92tmgEHvLRaBaqHuHd7KszKiD0cXYmGsu2dOsWID6yxE7Hiz K641isSMYe3ynCtwVPdE60oWOWnA36knF1gJ1OhRIdKR9WaINWQvYCT83OtoD8xee0 AdbKkMx+FsSC2yoBLBLMtTAydSP5s6Ohyy4HN1Gt6zOb3/KR9asnoVDfqAsXnjfpRY J5/CoN7xW7tOg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4QvkXX73qbz9rxB; Mon, 3 Jul 2023 13:41:32 +0200 (CEST) From: Ihor Radchenko To: Liu Hui Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] ob-python: support header argument `:results file graphics' In-Reply-To: References: <877crh8htb.fsf@localhost> Date: Mon, 03 Jul 2023 11:41:31 +0000 Message-ID: <875y71fcic.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1688384565; a=rsa-sha256; cv=none; b=T9AFLqvaPTMfPhwIeSl8XUAIhJK7HBAYr0DEdznqpHu2kMxpjWdmk6nTiKYWUwQxPQd4Xz k7SqrRQ7GfC6Ixu7KafUvjpIsQutX5BPhagJmx+rFrgyZMOM1hTyR3mWRgS/ZdmgxPs/Yt ksfGf9FWB0QWH6sOQmLT4gDEhEvQTRtrnWGlackL9dZJW9fh9ay2k8bXu6mY4iLaTbHpoR Upu2EdQfBoQ+skgo51rFU1F0avY7+hkGnmvUmLdILYQmjceetEZf8vuJvFZpPsMnCEqSzJ g3Hj7rnfe5WvnXtQl45eiK0QMhhgnRe9E4JofpRhlD1ot/ie1TMeOkQ9S7YTmQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=pYhv2Aak; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1688384565; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=jzvGGpaDZhKaen1deOy6zROMlz3AidfuIERJdqCIR4M=; b=EC2PV92eHPpKg/oc5W2XGB9DKaSCGkpCQhu9skY6hgyEpTNocrDp6D0uOAXyE9RIfBYDM9 1YDp1K4ne2XuWKYBz5WHNucGhSRAxyCciNtujjsfhpn3Um7gzwQuMgCALmq7gJlTOPN7/x OI6381BhZtN60CBRBAJ5jg5GjTA0MYBN6L+jnN3kwZ89MqTNPmVJXWmHRWGxOS7tKxtJs/ NEv/dmMdFc5AseoWCzBxyvIEnST6mcNDCDJnMuc4Ls/8DGiUmrH0lT0NTU9sglniybL2Pc blbXAgxlYT0v7uthXJS/peSg99ov5ty00LgniWeQ3L+f0bvOjdTY8lEerxlhRQ== Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=pYhv2Aak; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -11.33 X-Spam-Score: -11.33 X-Migadu-Queue-Id: A2886392A6 X-TUID: sMjZITDSvA7C Liu Hui writes: > I have updated the patch and =E2=80=98:file=E2=80=99 header argument can = be omitted > now, e.g. > > #+begin_src python :results graphics file > import matplotlib.pyplot as plt > plt.plot([1,2,3,4,5]) > plt.savefig('test.png') > return 'test.png' > #+end_src This already works, even without the patch. > In this case, `graphics' can be removed too. May you elaborate? #+begin_src python :results file implies that the result of execution is file _contents_. >> What if the user wants to use, for example, pyplot instead of >> matplotlib? > > pyplot is a module of matplotlib. If you mean users want to use other > graphics libraries, they may advise `org-babel-python-save-graphics' > if they want to use `graphics' in the header argument. If necessary, > ob-python may support such libraries too. This is not acceptable. If src blocks worked in the past, they should continue working without adjustments in user' setup. We can only break backwards-compatibility when there is a strong reason to do so. Adding a new feature is not such a reason. --=20 Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at