From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id qJBxGdJRtmSNHQAASxT56A (envelope-from ) for ; Tue, 18 Jul 2023 10:48:18 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id WP5TGdJRtmQDUAEA9RJhRA (envelope-from ) for ; Tue, 18 Jul 2023 10:48:18 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0FAFA3E0AD for ; Tue, 18 Jul 2023 10:48:18 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=lhjLhDNm; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1689670098; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=H69Q8/Szk6fkbK6UoEaS9JJI2bwfJ8UV9avolTJ3Ix8=; b=QB6FgIcYq+qP5R66czObQCqj+1QR3kRx7EpD8do4frTX1QGIQ7fRQTf2op0lJyTsdWn9FA 3ag8eNzjjP9QSnlEkL7YQ0FSiPC137D4RfUiYKHgu34B1Sf1CGliH8KvY92UySJFkIMuFz 99gqSstzpwz1Wg1R5inz7rObR6y70ysJK19+JuKQtzZudK5EsVJVsNnaWHTdb1V08qVhgE 2W4H8k1+/plXW+SErErtQdtgErw98JZO1gEcWmq5xjT81c7ZWqhQK4SseN9llHIFxKPYlZ g+fixVlnAUTo/mi4F0GlUlmFLl4bRASD2DYQWlEA6laW8zVhGEPx/5qwDsTg3A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1689670098; a=rsa-sha256; cv=none; b=BLPNS/kAIxUi+vUQN4HdtvSDteBG9OCtK+7CI5R2M3R2ja79amTdvMnRWvbbRP2XzWVoPD s4WlLTdeYJ92Q/Bmja7M5PngthBXXck8FfTVLkPrAnHotGDLn2iTLhMCxSkmsmMM5TNNS/ +QhLgjI+shRgjPodEHG3sO/DT2Ta6MtawJa8I9qWiWwyVAAoVPvmze7Ue3FwMh3667awOJ YxUqftcFuM48K1MmR/MfmG3JFf8En1eiFJNpYsYb/bwtizwicVBEG9zisHIn1awT9fRNwV t/6d8IluRKVPEdd/dxgjn2fuLwsnLN+HoxqZVIW5g3ugokoywegVg8WGYi7cRA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=lhjLhDNm; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qLgMp-00083Y-7d; Tue, 18 Jul 2023 04:47:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLgMn-00083M-Cq for emacs-orgmode@gnu.org; Tue, 18 Jul 2023 04:47:33 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLgMk-0005FX-0D for emacs-orgmode@gnu.org; Tue, 18 Jul 2023 04:47:33 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 113FD240028 for ; Tue, 18 Jul 2023 10:47:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1689670048; bh=E0hDJPN09gI2QIdDArnmYX5DpUIv1AX187bFokWVee0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=lhjLhDNmHhfOZopR9utHaURUYbybXS0Rt4weYvC7aSoENUXUo7p2HCoAPDRG2vB0b 2MViimOvqikiTT2R269rnNlrziybP20cYZ06+7CeGJRp2xIDII/s0Mfb06PEaH1hrF paEajaedLkOYLtXqRnhgD+SQMa6mkYAhvVWedz4nsuvxGo5rrkT/+Esdvh2+RYdvNH 4ayS3WjK2iGOUENi+iB+/BX/lCiWqyCj9dkNkCvcDdKsbsYu7OV95IrFSpJt2en+jO oSc9mv5FE9zS+dhTnvff8cuZkOqDF5Q2M3FFuV7lVsPotf5FX/4nWO9VDI6yAOR/Gy r/rOtqg9ddV3w== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4R4syl0Pbwz6tn4; Tue, 18 Jul 2023 10:47:26 +0200 (CEST) From: Ihor Radchenko To: Mehmet Tekman Cc: emacs-orgmode@gnu.org Subject: Re: [ANN] lisp/ob-tangle-sync.el In-Reply-To: References: <87r0rxabd4.fsf@localhost> <87sfcd78vw.fsf@gmail.com> <87r0rxv3t5.fsf@localhost> <87lei577g4.fsf@gmail.com> <87lei5v1fg.fsf@localhost> <87fs8duyae.fsf@localhost> <8735451u20.fsf@gmail.com> <874jokbjsk.fsf@localhost> <87zg6ch2dm.fsf@gmail.com> <87sfc4a0ce.fsf@localhost> <87r0ro9mzc.fsf@gmail.com> <87zg69zq49.fsf@localhost> <87r0rg1lwe.fsf@gmail.com> <87leho3y0n.fsf@localhost> <87a5y3vzpe.fsf@gmail.com> <87jzx6ylrm.fsf@localhost> <87ttw8kd9u.fsf@gmail.com> <87fs5ppcx7.fsf@localhost> Date: Tue, 18 Jul 2023 08:47:37 +0000 Message-ID: <875y6hwqqe.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -7.63 X-Spam-Score: -7.63 X-Migadu-Queue-Id: 0FAFA3E0AD X-Migadu-Scanner: mx1.migadu.com X-TUID: GalhYvb2qsQ9 Mehmet Tekman writes: >> ... I will rewrite to to conform to the >> `org-test-with-temp-text' examples. > > So I've just rewritten the `merge-params' testing function I > wrote before, this time using the `org-test-with-temp-text' > method/macro. Side note: You are re-implementing the already available ERT features for failed test reporting. Instead of controlling which tests failed manually, you should better follow the example of all other tests and simply use a sequence of `should'/`should-not' forms. If you did that, ERT would by itself report which tests fail and why. > I seem to be getting 5 failing tests for reasons that I'm not > quite sure why. I've tested it against upstream/main, but still > getting the same errors. Maybe you can try it and see where I'm > going wrong? I am getting the following failures: 6 Failed Blocks: (tangle-file-with-spaces override-document-and-heading-tfile-with-yes ignore-document-header-take-last-tfile-and-sync-action inherit-document-tfile-take-only-last-local-sync-action inherit-document-header-with-local-sync-action inherit-document-header-args) > + (let ((idtest-alist '((inherit-document-header-args > + :tangle "\ > +#+PROPERTY: header-args :tangle /tmp/default_tangle.txt > +* One > +#+begin_src conf > + (:tangle . /tmp/default_tangle.txt) > +#+end_src") This is failing because of subtlety in `org-test-with-temp-text' that inserts text after activating org-mode. PROPERTY lines are only computed when org-mode is activated, unless you explicitly call `org-set-regexps-and-options' to refresh them. Your code does not refresh those and PROPERTY line is not being handled by Org. Same story for other tests with PROPERTY. > + (tangle-file-with-spaces > + :tangle "\ > +* One > +:PROPERTIES: > +:header-args: :tangle \"foo.txt\" > +:END: > +** Two > +#+begin_src :tangle \"file with spaces.txt\" > + (:tangle . \"file with spaces.txt\") > +#+end_src"))) This fails because you did not provide LANG for source block. override-document-and-heading-tfile-with-yes test is also missing LANG. P.S. There going to be Emacs meetup this Saturday, July 22 (https://emacs-apac.gitlab.io/announcements/july-2023/). I plan to be there and, if you need it, we can try to resolve difficulties in more interactive way. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at