From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id ONtaKO6IwmU/cgEAe85BDQ:P1 (envelope-from ) for ; Tue, 06 Feb 2024 20:30:54 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id ONtaKO6IwmU/cgEAe85BDQ (envelope-from ) for ; Tue, 06 Feb 2024 20:30:54 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=daLQpdld; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1707247854; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=B0yJpBNC7u7sAJPUL32r83LuL2AXczsXiyYr1csEVMs=; b=qT/quIhf6GHsIsqu0XDXdgS1coogop2plhe12aXiQe8+rWqcdX4uAololuOFq6oal45UzQ pSYPQyVs1Vu0BJ9OXGcJ+NEGdcc41WAjZMMzo3T/nAbe1GMWiMiv7YrexAyHp6xzV55TbR HO9KTCcF2KHn/ijVYOhimvbtIieusB+I396K52C8biPjkXBrccjaDXm0LX+f/gEy4pgYJS IQRt3PQwLU9jJFsonx9r7LeNiRLHzJQTnU9Rm6/r1YLm447WKuIGB9gCuuYyLLDvHUgyFj np+zQiRchY4aEzuvJIUEzB8LR4gw5RK0fpuP1BYXwKnOMtL1CeV+FEYsdisA/A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=daLQpdld; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1707247854; a=rsa-sha256; cv=none; b=hclZHW3R3zHgMEyihiixj2106RuFicQVTzEZsgrsBiqchuvxnBrFTZ49eECx0lPX6KidJf ns8GwA4XB8VNKjcThJaWvpOCRs2J68gDzsAnUYGMdmcGXUk/3sMShzQH/gEci6EQnJfgJJ j6NJ6e5lntgk/m/rRBj/j9nXBOZ1LYy8QZifnT7BkrsmsnWbDnBw3RXpSWbYvXOqMbGuI4 mnCqdiMGK6KLsDXJkMLsLIQzGToL6eU6UHKAXfpdN02hXMBIO/wZbzqu6wZTciuorg3XjC LeC9XdkC3Wh7BlWSSkEvjGDQZ0tJ/rkTr0aie8EF/3EE/zaJUc6F0sEa0AQnRQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8D1F23781B for ; Tue, 6 Feb 2024 20:30:54 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rXR8x-0001E2-Tz; Tue, 06 Feb 2024 14:30:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rXR8r-0001DX-Cj for emacs-orgmode@gnu.org; Tue, 06 Feb 2024 14:30:01 -0500 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rXR8k-0004dt-BF for emacs-orgmode@gnu.org; Tue, 06 Feb 2024 14:30:00 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id EA307240101 for ; Tue, 6 Feb 2024 20:29:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1707247786; bh=zbmxeVZKer6OuuM942BCxPz50bwwgMsCxdRd4R67xec=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: Content-Transfer-Encoding:From; b=daLQpdldnHgfSYWWmSSMXNCIxbH7dGcvs2F2xD9ZCGBDPuOskPjOEpaVowofkxq3M gYE5JOka0DOd9qdg6IkMkN/7abzASIprQqT/sInQbd0lmAaH3OlZoVHiH+4rWp92UV 9vfh3HKZHGqVloH50b3cJ/JeHDi2LcCZnAF8wnKpTA8B7ZRFOpNXe3D0nyJkHLZE+1 AlC+8PuaIf2VL0QFEvE3C69She5Gk1ozY0uNkux3LTZSiuawwH8LJ7eRXoTnjxRxj+ wdBvhircEJAxicSLmcIjBHhe6BStAhaYkYhpdJiVjofUWnT+g/4AL+GgSKkSf779hT 0Wo2P/gQBsHAw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4TTtc92Rnmz6txj; Tue, 6 Feb 2024 20:29:45 +0100 (CET) From: Ihor Radchenko To: =?utf-8?Q?S=C5=82awomir?= Grochowski Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] lisp/org-colview.el: [refactor] [extract function] `org-columns-move-up' & `org-columns-move-down' In-Reply-To: <87mssg13t4.fsf@localhost> References: <8734u82ipf.fsf@gmail.com> <87mssg13t4.fsf@localhost> Date: Tue, 06 Feb 2024 19:33:12 +0000 Message-ID: <875xz1fkw7.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -9.57 X-Spam-Score: -9.57 X-Migadu-Queue-Id: 8D1F23781B X-Migadu-Scanner: mx12.migadu.com X-TUID: hAauPIJQoBRs Ihor Radchenko writes: > S=C5=82awomir Grochowski writes: > >> +(defun org-columns-move-up () >> + (interactive) >> ... >> +(defun org-columns-move-down () >> + (interactive) >> ... > > May you also add docstrings? > And maybe better names would be org-columns-next/previous-line. > ... Applied, onto main. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=3D18d98ee65 --=20 Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at