From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Eric Schulte" Subject: Re: Prompts again WAS Re: avoiding source block prompts Date: Wed, 28 Jul 2010 08:03:02 -0600 Message-ID: <874ofj63dw.fsf@gmail.com> References: <87bp9sbxe6.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from [140.186.70.92] (port=45000 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Oe8PJ-0006nU-R0 for emacs-orgmode@gnu.org; Wed, 28 Jul 2010 11:19:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Oe8PG-0006ZS-1i for emacs-orgmode@gnu.org; Wed, 28 Jul 2010 11:18:57 -0400 Received: from mail-gx0-f169.google.com ([209.85.161.169]:48739) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Oe8PF-0006ZL-TC for emacs-orgmode@gnu.org; Wed, 28 Jul 2010 11:18:54 -0400 Received: by gxk4 with SMTP id 4so2309988gxk.0 for ; Wed, 28 Jul 2010 08:18:53 -0700 (PDT) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: "Charles C. Berry" Cc: emacs-orgmode@gnu.org Thanks Chuck, I've just swapped in your new and improved regexp. I share your concern both that there could be cases where prompts aren't matched, or more seriously where the actual output looks like a prompt (e.g. user returns a prompt-like string). Before taking this explicit prompt removal approach I tried automatically removing comment lines from the input before passing it to the inferior R process, however that ran into similar problems of users potentially inputting valid strings which look like comments -- which would be hard to catch without implementing a fairly sophisticated R parser as part of Babel. This new regexp looks like the best option for now. Thanks! -- Eric "Charles C. Berry" writes: > Eric, > > In ob-R.el, changing this > > (if (string-match "^\\([ >]+\\)\\[[0-9]+\\]" line) > > to this > > (if (string-match "^\\([ ]*[>+][ ]?\\)+\\([[0-9]+\\|[ ]\\)" line) > > seems to fix things (note I added plus sign which is the continuation > prompt in R). > > I tried it on a bunch of varied source blocks and it seems to work OK, > but I worry that there may be case where it will fail. > > Chuck > > > On Tue, 27 Jul 2010, Charles C. Berry wrote: > >> >> Eric, >> >> I spoke too soon. >> >> Have a look at the following. You'll see that the prompts show up there. :-( >> >> Chuck >> >> #+begin_src R :session :results output >> ### create x >> x <- data.frame(a=rnorm(2),b=rnorm(2)) >> ### now print the result >> x >> #+end_src >> >> #+results: >> : >> : > > a b >> : 1 0.2702748 -0.2938296 >> : 2 1.1095136 0.1769425 >> >> >> >> On Tue, 27 Jul 2010, Charles C. Berry wrote: >> >>> On Tue, 27 Jul 2010, Eric Schulte wrote: >>> >>> > Hi Charles, >>> > > I just pushed up a fix for the extra prompts in your output. >>> You will >>> > still have a blank line (the output from "x <- rnorm(1)"), however you >>> > can suppress that line by placing the "x <- rnorm(1)" command in a >>> > previous code block in the same session. >>> >>> Eric, >>> >>> Thanks. That works for me. >>> >>> Chuck >>> >>> > > Best -- Eric >>> > > "Charles C. Berry" writes: >>> > > > I think this is a new feature or perhaps a bug, which I >>> noticed when >>> > > upgrading to version 7.01. >>> > > > > The newline and the two prompts '> >' in the results >>> block below did >>> > > not show up in the earlier versions I used. >>> > > > > If this is a 'feature', is there a clean way to change >>> this behavior? >>> > > > > If this is a bug, is there a simple patch to fix it? >>> > > > > #+begin_src R :session :results output >>> > > ### create x >>> > > x <- rnorm(1) >>> > > ### now print the result >>> > > x >>> > > #+end_src >>> > > > > #+results: >>> > > : >>> > > : > > [1] 2.186783 >>> > > > > > > What I would have liked is to have something that >>> looks like this: >>> > > > > #+results: >>> > > : [1] 2.186783 >>> > > > > Thanks, >>> > > > > Chuck >>> > > > > > > Charles C. Berry (858) >>> 534-2098 >>> > > Dept of >>> Family/Preventive > > Medicine >>> > > E mailto:cberry@tajo.ucsd.edu UC San Diego >>> > > http://famprevmed.ucsd.edu/faculty/cberry/ La Jolla, San >>> Diego > > 92093-0901 >>> > > > > > > > > _______________________________________________ >>> > > Emacs-orgmode mailing list >>> > > Please use `Reply All' to send replies to the list. >>> > > Emacs-orgmode@gnu.org >>> > > http://lists.gnu.org/mailman/listinfo/emacs-orgmode >>> > >>> >>> Charles C. Berry (858) 534-2098 >>> Dept of Family/Preventive >>> Medicine >>> E mailto:cberry@tajo.ucsd.edu UC San Diego >>> http://famprevmed.ucsd.edu/faculty/cberry/ La Jolla, San Diego 92093-0901 >>> >>> >>> >>> _______________________________________________ >>> Emacs-orgmode mailing list >>> Please use `Reply All' to send replies to the list. >>> Emacs-orgmode@gnu.org >>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode >>> >>> >> >> Charles C. Berry (858) 534-2098 >> Dept of Family/Preventive >> Medicine >> E mailto:cberry@tajo.ucsd.edu UC San Diego >> http://famprevmed.ucsd.edu/faculty/cberry/ La Jolla, San Diego 92093-0901 >> >> >> >> _______________________________________________ >> Emacs-orgmode mailing list >> Please use `Reply All' to send replies to the list. >> Emacs-orgmode@gnu.org >> http://lists.gnu.org/mailman/listinfo/emacs-orgmode >> > > Charles C. Berry (858) 534-2098 > Dept of Family/Preventive Medicine > E mailto:cberry@tajo.ucsd.edu UC San Diego > http://famprevmed.ucsd.edu/faculty/cberry/ La Jolla, San Diego 92093-0901