From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <n.goaziou@gmail.com>
Subject: Re: Re: [PATCH] Alphabetical ordered lists
Date: Thu, 11 Nov 2010 09:57:58 +0100
Message-ID: <874obo44q1.wl%n.goaziou@gmail.com>
References: <AANLkTimGVyxJfkxdBWOTipo_PD3mfHHsEL_mMX2jgmb9@mail.gmail.com>
	<BA8106A9-1341-4130-8001-A6A3F3D632E3@gmail.com>
	<87bp8o498o.fsf@gollum.intra.norang.ca>
	<AANLkTindBSTCqZnh4Ps=ijwfcdLfXg0id+unrTwOawis@mail.gmail.com>
	<AANLkTikp8y1JftoTOEQ3J6TydNVfKQdTD1vHY3kTHR6V@mail.gmail.com>
	<AANLkTi=JORE+E7Hz_HU-_kmQ9UKPnq5da5iTm2xtG_4_@mail.gmail.com>
	<393C5110-E4D3-4B36-8F4E-4F94B5AA0F93@gmail.com>
	<87k4m876g3.wl%n.goaziou@gmail.com>
	<AANLkTi=u8TZ8iMJ4wy9R_3Lm6Z-z0O0QQw1wgqPdWg4U@mail.gmail.com>
	<87iq1r7k00.wl%n.goaziou@gmail.com>
	<BBA95B8F-BD80-491D-B946-0E2CDEA78913@gmail.com>
	<747F5104-6B1C-43E8-BF42-883287B7E303@gmail.com>
	<87aan0789y.wl%n.goaziou@gmail.com>
	<AANLkTinBQSSLw8zmZpv_wAPbBf3yOPKDCMfzNwomf4gy@mail.gmail.com>
	<BD5DF6C1-9702-4801-BB34-688CBEA35A52@gmail.com>
	<874od127wq.wl%n.goaziou@gmail.com>
	<535BC60F-1310-47AD-BCD1-1C88822B852A@gmail.com>
	<AANLkTimuPCY3ur0LN6=bBBzaokRt+SaP9Wzqo8+wtKL9@mail.gmail.com>
	<AANLkTi=2KW_r1C76Z0uqXD2xF-_42zLYwakrsRWMDdYG@mail.gmail.com>
	<87y69lqs8z.wl%n.goaziou@gmail.com>
	<4849E760-2A8F-49A4-9B29-347BD3645D1A@gmail.com>
	<AANLkTimW3LFZ2cOL5DkThkXtiVR3EFcOA6Wkg+_+f_Ny@mail.gmail.com>
	<AANLkTi=o4sC0==WRfj8NGA_5EsGxm_Auwqus6G_NQSco@mail.gmail.com>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from [140.186.70.92] (port=37171 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PGSyt-0003zZ-CC
	for emacs-orgmode@gnu.org; Thu, 11 Nov 2010 03:58:10 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <n.goaziou@gmail.com>) id 1PGSyl-00010f-2v
	for emacs-orgmode@gnu.org; Thu, 11 Nov 2010 03:58:00 -0500
Received: from mail-wy0-f169.google.com ([74.125.82.169]:37359)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <n.goaziou@gmail.com>) id 1PGSyk-00010Q-UD
	for emacs-orgmode@gnu.org; Thu, 11 Nov 2010 03:57:59 -0500
Received: by wyf23 with SMTP id 23so1952618wyf.0
	for <emacs-orgmode@gnu.org>; Thu, 11 Nov 2010 00:57:57 -0800 (PST)
In-Reply-To: <AANLkTi=o4sC0==WRfj8NGA_5EsGxm_Auwqus6G_NQSco@mail.gmail.com>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Nathaniel Flath <flat0103@gmail.com>
Cc: Bernt Hansen <bernt@norang.ca>, Jacob Mitchell <jacob.d.mitchell@gmail.com>, org-mode List <emacs-orgmode@gnu.org>, Carsten Dominik <carsten.dominik@gmail.com>

Hello,

>>>>> Nathaniel Flath writes:

> Are there any further issues? Thanks, Nathaniel Flath

I've quick checked your patch and it looks like it is doing its job.

Two things to note, though:

1. I strongly recommend that `org-list-can-be-alphabetical' should
   make use of non-interactive forms instead of interactive ones. In
   other words, you should use `org-get-beginning-of-list' and
   `org-get-next-item' instead of `org-beginning-of-item-list' and
   `org-next-item'. You can see my note about it in org-list.el at
   line 856.

   If you have the structure of the list, `caadr' on it (or an
   equivalent if you don't like cl.el) will give you a valid top item
   needed by non-interactive forms.

2. Your patch doesn't apply to current git head, you should correct
   the conflict.


Regards,

-- Nicolas