From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bastien <bzg@altern.org>
Subject: Re: [PATCH]: New Add defun org-mode-or-derived-mode-p
Date: Sat, 22 Oct 2011 11:31:21 +0200
Message-ID: <874nz1jrti.fsf@gnu.org>
References: <m0r53zw696.fsf@ge-research.com> <871uvz56th.fsf@thinkpad.tsdh.de>
	<m0r53vh48x.fsf@ge-research.com> <87wrdnigpd.fsf@thinkpad.tsdh.de>
	<61054BA2-E0B8-40B9-B62E-FB0EB04E99CF@gmail.com>
	<87fwj0gfny.fsf@thinkpad.tsdh.de>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([140.186.70.92]:43066)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@googlemail.com>) id 1RHXuR-0001QG-NV
	for emacs-orgmode@gnu.org; Sat, 22 Oct 2011 05:30:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bastienguerry@googlemail.com>) id 1RHXuQ-00011f-Nm
	for emacs-orgmode@gnu.org; Sat, 22 Oct 2011 05:30:31 -0400
Received: from mail-wy0-f169.google.com ([74.125.82.169]:38576)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@googlemail.com>) id 1RHXuQ-00011Z-Cp
	for emacs-orgmode@gnu.org; Sat, 22 Oct 2011 05:30:30 -0400
Received: by wyg34 with SMTP id 34so5596544wyg.0
	for <emacs-orgmode@gnu.org>; Sat, 22 Oct 2011 02:30:29 -0700 (PDT)
In-Reply-To: <87fwj0gfny.fsf@thinkpad.tsdh.de> (Tassilo Horn's message of
	"Tue, 11 Oct 2011 09:18:09 +0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Tassilo Horn <tassilo@member.fsf.org>
Cc: emacs-orgmode@gnu.org, Carsten Dominik <carsten.dominik@gmail.com>

Hi Tassilo,

Tassilo Horn <tassilo@member.fsf.org> writes:

> Ups, I've slightly misread your suggestion.  Currently, there is only
> one place in org-src.el that check for being a mode derived from
> org-mode or org-mode itself.  The second is useless, because
> (derived-mode-p 'org-mode) is true for org-mode, too.
>
> But as I've said, I've misread your suggestion and made a patch that
> completely erases org-mode-p and all its calls.  Feel free to apply or
> discard it. :-)

I applied this patch -- thanks for it.

IMHO another reason for using (eq major-mode 'org-mode) instead of
(org-mode-p) is that new contributors are likely to use this more
explicit (though longer) expression before they find out that a 
defsubst is available for that.

-- 
 Bastien