From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: bug#11249: 24.1.50; Overlay with face property causes calendar buffer to scroll Date: Sun, 22 Apr 2012 08:46:03 +0200 Message-ID: <874nsctgb8.fsf@gnu.org> References: <8762cuy5rw.fsf@altern.org> <20120421193406.GA1111@c3po.home> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([208.118.235.92]:33324) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SLqXa-0007We-CG for emacs-orgmode@gnu.org; Sun, 22 Apr 2012 02:44:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SLqXY-00070L-Ed for emacs-orgmode@gnu.org; Sun, 22 Apr 2012 02:44:57 -0400 Received: from mail-wg0-f49.google.com ([74.125.82.49]:32973) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SLqXY-0006y4-6E for emacs-orgmode@gnu.org; Sun, 22 Apr 2012 02:44:56 -0400 Received: by wgbdr1 with SMTP id dr1so8051192wgb.30 for ; Sat, 21 Apr 2012 23:44:54 -0700 (PDT) In-Reply-To: <20120421193406.GA1111@c3po.home> (Toby Cubitt's message of "Sat, 21 Apr 2012 21:34:06 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Toby Cubitt writes: > Thanks for the fix. I notice that the new face's dosctring still says > "Face for deadlines and TODO keywords", which needs changing. Fixed, thanks. > Was there some reason to reject Eli's suggested fix of enlarging the > calendar window by 1 line? As it stands, if anyone customizes the new > org-date-selected face to be bold (the highlighted date *is* a little > less visible now), it will cause the same problem as before. And the fact > that it's caused by making the font bold is not at all obvious...at > least, it wasn't obvious to me! Eli's fix works more generally. This general solution comes with a cost -- enlarging the window by one-line for everyone just because a few users will use bold fonts and have a problem while displaying... does not feel right to me. > Anyway, since I now know how to patch things if I do decide I want a bold > font, it's not a big issue for me. > > In the patch I posted, I also took the opportunity to set `cursor-type' > to nil when opening the calendar in `org-read-date'. The cursor obscures > one digit of the selected date, making that bit harder to read (as well > as looking ugly). Did you intend to reject this change too? I did because I found the not-bold-anymore face wasn't visible enough, and the shallow cursor made it visible. I use inverse-video now for this face, so cursor-type nil is okay, I applied a patch with this. -- Bastien