From mboxrd@z Thu Jan 1 00:00:00 1970 From: Max Mikhanosha Subject: Re: [PATCH] speedup redisplay of agenda item after change Date: Sun, 30 Sep 2012 16:29:05 -0400 Message-ID: <874nmftfu6.wl%max@openchat.com> References: <87mx0at72e.wl%max@openchat.com> <87wqzds5oy.fsf@bzg.ath.cx> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: Received: from eggs.gnu.org ([208.118.235.92]:52882) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TIQ8S-0008Qs-Bt for emacs-orgmode@gnu.org; Sun, 30 Sep 2012 16:29:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TIQ8R-0007OM-8m for emacs-orgmode@gnu.org; Sun, 30 Sep 2012 16:29:08 -0400 Received: from openchat.com ([75.99.81.170]:43806 helo=momoland.openchat.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TIQ8R-0007O0-4R for emacs-orgmode@gnu.org; Sun, 30 Sep 2012 16:29:07 -0400 In-Reply-To: <87wqzds5oy.fsf@bzg.ath.cx> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bastien Cc: emacs-orgmode@gnu.org At Sat, 29 Sep 2012 08:21:08 +0200, Bastien wrote: > > Max Mikhanosha writes: > > > Following patch changes (org-agenda-change-all-lines) to call > > (org-agenda-finalize) for each line changed, with agenda buffer > > narrowed to just that line, and it speeds up redisplay of current item > > a lot, the Shift-Up changing of priority can almost keep up with > > keyboard repeat rate on large agendas. > > This is a great optimization trick, thanks a lot for this patch, > I just applied it. > > > I was running with this patch for a month, and did not noticed any > > problems so far. > > Did you run it with latest Org from maint, from master? No sorry I had not tried with maint, just with head of the repository. > Also, would you like to get push access to the repo? I'd be glad. > Just send me your public key if so. I've had commit access (for sticky agenda), so unless someone removed me I should still have it. The reason I did not commit it directly, that its kind of innocent looking change but in the sensitive area of the code, so I wanted more eyes / testing on it first. If there is anything broken by it, my guess it could bulk commands, clocking and/or undo stuff, and I'm not these much. Regards, Max