From: Achim Gratz <Stromeko@nexgo.de>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Do not indent option keywords
Date: Fri, 10 May 2013 08:39:30 +0200 [thread overview]
Message-ID: <874nebfie5.fsf@Rainer.invalid> (raw)
In-Reply-To: 41207E77-189F-40AB-909D-3581EFA38288@gmail.com
Carsten Dominik writes:
> by decoration you mean font-lock support?
Yes, but I also don't think these should ever become indented in the
first place. That's debatable of course, the syntax as defined by
org-element does not require this IIRC.
> Maybe this would be a better fix:
>
> Modified lisp/org.el
> diff --git a/lisp/org.el b/lisp/org.el
> index 745fb82..43df094 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -5867,7 +5867,8 @@ by a #."
> ((or (equal dc1 "+results")
> (member dc1 '("+begin:" "+end:" "+caption:" "+label:"
> "+orgtbl:" "+tblfm:" "+tblname:" "+results:"
> - "+call:" "+header:" "+headers:" "+name:"))
> + "+call:" "+header:" "+headers:" "+name:"
> + "+options:"))
> (and (match-end 4) (equal dc3 "+attr")))
> (add-text-properties
> beg (match-end 0)
Sure, that helps too and has certainly less potential for controversy.
I think we should make an effort to shift most if not all the regex
stuff in org.el into org-element. There's far too much duplication with
subtle differences sprinkled all over the place to get match data to
work with and it's almost hopeless to try and find all such uses for a
single element.
Regards,
Achim.
--
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+
Factory and User Sound Singles for Waldorf rackAttack:
http://Synth.Stromeko.net/Downloads.html#WaldorfSounds
next prev parent reply other threads:[~2013-05-10 6:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-09 19:14 [PATCH] Do not indent option keywords Achim Gratz
2013-05-09 20:34 ` Achim Gratz
2013-05-10 6:26 ` Carsten Dominik
2013-05-10 6:39 ` Achim Gratz [this message]
2013-05-10 17:57 ` Carsten Dominik
2013-05-10 18:30 ` Achim Gratz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874nebfie5.fsf@Rainer.invalid \
--to=stromeko@nexgo.de \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).