From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Abrahamsen Subject: Re: How to find the headline matching a string Date: Sun, 01 Jun 2014 12:05:03 +0800 Message-ID: <874n05e0ls.fsf@ericabrahamsen.net> References: <87bnuedl38.fsf@ericabrahamsen.net> <87ha45r9hi.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50423) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wqwy0-0004Lr-Q9 for emacs-orgmode@gnu.org; Sun, 01 Jun 2014 00:01:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wqwxu-0002h0-5W for emacs-orgmode@gnu.org; Sun, 01 Jun 2014 00:01:52 -0400 Received: from plane.gmane.org ([80.91.229.3]:37350) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wqwxt-0002gw-Ug for emacs-orgmode@gnu.org; Sun, 01 Jun 2014 00:01:46 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1Wqwxr-0001Rr-Mf for emacs-orgmode@gnu.org; Sun, 01 Jun 2014 06:01:43 +0200 Received: from 123.123.23.241 ([123.123.23.241]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 01 Jun 2014 06:01:43 +0200 Received: from eric by 123.123.23.241 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 01 Jun 2014 06:01:43 +0200 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Thorsten Jolitz writes: > Chris Poole writes: > >> Eric Abrahamsen: >>> the `org-map-entries' function can be given a scope of 'agenda >> >> That worked perfectly, thanks. Here's what I ended up with: >> >> (org-map-entries (lambda () >> (when (equal title (org-get-heading t t)) >> (org-entry-put (point) "TODO" "DONE"))) >> tag 'agenda) > > As much as I like the powerful `org-map-entries', I wonder if it will > coexist with `org-element-map' in the future, since it does not use the > new parser. > > Whats the recommendation here? Should one rather use > > ,----------------------------------------------------------- > | (org-element-map (org-element-parse-buffer) 'headline (lambda () ...)) > `----------------------------------------------------------- > > nowadays, or do both functions serve different purposes, or is it just a > matter of taste? Interesting! I wasn't even aware of org-element-map, thanks for that. Obviously I don't know the answer to your question, but they do seem to do very similar things. On the other hand, `org-element-map' won't do multiple files, and if you want to restrict to certain elements you have to do the matching logic yourself (as opposed to `org-map-entries's agenda-style search string). I'd be curious, too, to hear if `org-map-entries' is going to get EOL'd at some point. I suppose it's safe so long as `org-scan-tags' remains the heart of the agenda process. Here's my stab at two roughly equivalent functions, one using org-element, the other older function. Just for the hell of it I tried using "benchmark" to profile them, but have no idea if the results mean much of anything. Most importantly, I don't really know if `org-element-parse-buffer' ends up using the cache or not -- I assume not. (defun my-find-title-element-map (title) (interactive "sTitle: ") (let ((files (org-agenda-files)) found) (dolist (f files) (with-current-buffer (org-get-agenda-file-buffer f) (org-element-map (org-element-parse-buffer 'headline) 'headline (lambda (hl) (when (string= title (org-element-property :title hl)) (push (move-marker (make-marker) (org-element-property :begin hl)) found)))))) found)) (defun my-find-title-entries-map (title) (interactive "sTitle: ") (let (found) (org-map-entries (lambda () (when (string= title (org-get-heading t t)) (push (move-marker (make-marker) (line-beginning-position)) found))) nil 'agenda) found)) (benchmark-run 100 (my-find-title-element-map "Unique Heading Text")) => (164.576821235 142 23.892782392000186) (benchmark-run 100 (my-find-title-entries-map "Unique Heading Text")) => (58.111630133 36 6.047778745000016) This isn't quite an idle inquiry: part of Gnorb does exactly this (scanning all agenda files for headings with a certain property value). While using `org-map-entries' in an interactive function is currently good enough, I'd eventually like to have it happen more often, and quickly, in non-interactive functions. I was considering making my own mini-cache, but if `org-element-map' can do it, and do it quickly (presumably using the cache), I'd much prefer using that. Thanks, Eric