emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Thomas Morgan <tlm@ziiuu.com>
To: emacs-orgmode@gnu.org
Subject: Standard skipping conditions have no effect
Date: Sun, 01 Jun 2014 19:21:01 -0400	[thread overview]
Message-ID: <874n04usgy.fsf@azha.ziiuu.com> (raw)

Hello, Org mode hackers,

Here is a recipe for a bug on the maint branch that causes standard
skipping conditions to have no effect.

1. Change the load path setting in `setup.el'.

2. Start Emacs with `emacs -Q -l setup.el'.

3. Customize the agenda commands with `M-x org-agenda C'.

4. Add a new command, change the match field to tag `foo', and add a
   standard skipping condition for TODO states, so that the command
   looks like this in the customization buffer:

   ,----
   | INS DEL Choice: Value Menu Single command:
   |             Access Key(s) : x
   |             [X] Description: Describe command here
   |             Choice: Value Menu Tags/Property match (all agenda files)
   |             Match (only for some commands): foo
   |             Local settings for this command.  Remember to quote values:
   |             INS DEL Setting: Value Menu Standard skipping condition:
   |                         org-agenda-skip-function
   |                         List:
   |                         List:
   |                         Skipping range: Value Menu Skip entry
   |                         Conditions for skipping:
   |                         INS DEL Condition type: Value Menu TODO state is:
   |                                     todo
   |                                     Choice: Value Menu any not-done state
   |                         INS
   |             INS
   |             [ ] Export:
   |                 INS
   `----

5. Type `M-x org-agenda x'.  The resulting agenda view looks like this:

   ,----
   | Headlines with TAGS match: foo
   | Press `C-u r' to search again with new search string
   |   test-case:  TODO Buckle my shoe                                          :foo:
   `----

   I expected the TODO item to be filtered out.

   This is the value of `org-agenda-custom-commands':

   ,----
   | (("x" "Describe command here" tags "foo"
   |   ((org-agenda-skip-function
   |     '(org-agenda-skip-entry-if todo todo))))
   |  ("n" "Agenda and all TODO's"
   |   ((agenda "" nil)
   |    (alltodo "" nil))
   |   nil))
   `----

   The problem seems to be that the arguments to
   `org-agenda-skip-entry-if' are unquoted.  The following steps verify
   that.

6. Change `org-agenda-custom-commands', quoting the arguments to
   `org-agenda-skip-entry-if'.

   ,----
   | (setq org-agenda-custom-commands
   |       '(("x" "Describe command here" tags "foo"
   |          ((org-agenda-skip-function
   |            '(org-agenda-skip-entry-if 'todo 'todo))))
   |         ("n" "Agenda and all TODO's"
   |          ((agenda "" nil)
   |           (alltodo "" nil))
   |          nil)))
   `----

7. Remake the custom agenda view with `M-x org-agenda x'.

   ,----
   | Headlines with TAGS match: foo
   | Press `C-u r' to search again with new search string
   `----

   As expected, the TODO item is filtered.

Best,

Thomas

             reply	other threads:[~2014-06-02  1:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-01 23:21 Thomas Morgan [this message]
2014-06-02  1:00 ` Standard skipping conditions have no effect Thomas Morgan
2014-06-02 11:30 ` Bastien
2014-06-02 14:03   ` Thomas Morgan
2014-06-02 17:59     ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874n04usgy.fsf@azha.ziiuu.com \
    --to=tlm@ziiuu.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).