From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daimrod Subject: bug#17746: bug#17746: 24.4.50; "byte-code: `recenter'ing a window that does not display current-buffer." when composing a message Date: Thu, 12 Jun 2014 18:27:51 +0900 Message-ID: <874mzqeaug.fsf__22767.2755755068$1402565401$gmane$org@tanger.home> References: <837g4o1x3r.fsf@gnu.org> <87r42vlavi.fsf@geodiff-mac3.ulb.ac.be> <87ha3rxx79.fsf@bzg.ath.cx> <87ppifudvd.fsf@tanger.home> <878up24k6j.fsf@yahoo.fr> <878up2ec7z.fsf@tanger.home> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35598) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wv1Jk-0003kT-EP for emacs-orgmode@gnu.org; Thu, 12 Jun 2014 05:29:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wv1Je-0006OL-M6 for emacs-orgmode@gnu.org; Thu, 12 Jun 2014 05:29:08 -0400 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <878up2ec7z.fsf@tanger.home> (daimrod@gmail.com's message of "Thu, 12 Jun 2014 17:58:08 +0900") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Nicolas Richard Cc: Bastien , 17746@debbugs.gnu.org, David Griffiths Daimrod writes: > Nicolas Richard writes: > >> Daimrod writes: >>>> PS: The change about throwing an error when recentering a window >>>> that does not display the current buffer breaks ~37 tests in Org >>>> master branch, even with this fix. I need to digg this further. >>> >>> Err, what's the rational behind this change? >> >> It is meant to catch cases where recenter acts on the wrong window. >> Think of the cases where (recenter) is called from within a timer or a >> process filter function. >> >> See the discussion entitled >>> comint-preoutput-filter-functions and flickering redisplay in TTY >> on emacs devel. > > Thanks! Okay, so is there another fix than `(when (eq (current-buffer) (window-buffer)))' or removing the call? If not, why does it raise an error instead of doing nothing silently? Best, -- Daimrod/Greg