* [PATCH] org-src: Fix reference to free variable
@ 2015-05-23 19:30 Kyle Meyer
2015-05-23 19:53 ` Nicolas Goaziou
0 siblings, 1 reply; 2+ messages in thread
From: Kyle Meyer @ 2015-05-23 19:30 UTC (permalink / raw)
To: Org-mode
[-- Attachment #1: Type: text/plain, Size: 153 bytes --]
Hello,
The attached patch fixes a void variable error that occurs when remote
editing an empty footnote. (This was introduced by commit
71641bc3a08.)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-org-src-Fix-reference-to-free-variable.patch --]
[-- Type: text/x-diff, Size: 1204 bytes --]
From 9ba6a2f4af05c1104c678d959ff285bc7df5a70a Mon Sep 17 00:00:00 2001
From: Kyle Meyer <kyle@kyleam.com>
Date: Sat, 23 May 2015 15:18:07 -0400
Subject: [PATCH] org-src: Fix reference to free variable
* lisp/org-src.el (org-src--contents-area): Replace a let with let*.
---
lisp/org-src.el | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/lisp/org-src.el b/lisp/org-src.el
index 5201dca..88c8dd2 100644
--- a/lisp/org-src.el
+++ b/lisp/org-src.el
@@ -273,10 +273,10 @@ (defun org-src--contents-area (datum)
(let ((type (org-element-type datum)))
(cond
((eq type 'footnote-definition)
- (let ((beg (org-with-wide-buffer
- (goto-char (org-element-property :post-affiliated datum))
- (search-forward "]")))
- (end (or (org-element-property :contents-end datum) beg)))
+ (let* ((beg (org-with-wide-buffer
+ (goto-char (org-element-property :post-affiliated datum))
+ (search-forward "]")))
+ (end (or (org-element-property :contents-end datum) beg)))
(list beg end (buffer-substring-no-properties beg end))))
((org-element-property :contents-begin datum)
(list (org-element-property :contents-begin datum)
--
2.4.1
[-- Attachment #3: Type: text/plain, Size: 9 bytes --]
--
Kyle
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] org-src: Fix reference to free variable
2015-05-23 19:30 [PATCH] org-src: Fix reference to free variable Kyle Meyer
@ 2015-05-23 19:53 ` Nicolas Goaziou
0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Goaziou @ 2015-05-23 19:53 UTC (permalink / raw)
To: Kyle Meyer; +Cc: Org-mode
Hello,
Kyle Meyer <kyle@kyleam.com> writes:
> The attached patch fixes a void variable error that occurs when remote
> editing an empty footnote. (This was introduced by commit
> 71641bc3a08.)
Applied. Thank you.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-05-23 19:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-23 19:30 [PATCH] org-src: Fix reference to free variable Kyle Meyer
2015-05-23 19:53 ` Nicolas Goaziou
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).