From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kyle Meyer Subject: Re: fa5fd6351605912ec75e783cb62649 breaks org-babel-script-escape for ob-ruby Date: Tue, 11 Aug 2015 20:52:05 -0400 Message-ID: <874mk5coqy.fsf@kmlap.domain.org> References: <87h9o5316t.fsf@kyleam.com> <87bned311f.fsf@kyleam.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:46926) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPKH4-0007x4-Un for emacs-orgmode@gnu.org; Tue, 11 Aug 2015 20:52:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZPKH1-0003Fs-Ow for emacs-orgmode@gnu.org; Tue, 11 Aug 2015 20:52:10 -0400 Received: from mail-qg0-f41.google.com ([209.85.192.41]:35216) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPKH1-0003Fo-LA for emacs-orgmode@gnu.org; Tue, 11 Aug 2015 20:52:07 -0400 Received: by qgj62 with SMTP id 62so1535140qgj.2 for ; Tue, 11 Aug 2015 17:52:07 -0700 (PDT) In-Reply-To: (Matthew MacLean's message of "Tue, 11 Aug 2015 22:46:06 +0000") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Matthew MacLean Cc: emacs-orgmode@gnu.org Matthew MacLean wrote: > Yeah, my initial patch was actually for ob-ruby, though, when looking for > the change that broke it for the report, I found a change in behaviour of > the escaping function and figured that Ruby might not be the only thing > broken. Yes, that makes sense, but glancing at all lisp/ob-*.el files that use org-babel-script-escape, ob-ruby.el seems to be the only one that makes a double call to org-babel-script-escape, so I'd guess it is being called with a string in all other cases. > So, instead, I restored the original permissive behaviour of > org-babel-script-escape and made a patch of that instead. Given that org-babel-script-escape gives a clear error message, I'd prefer to keep the stricter variant and fix any offending calls. Feel free to wait to hear others' thoughts on this, but, in any case, please use 'git format-patch' to generate a patch with a commit message (see the contributing section of the website [1] for more information). Also, it'd be nice to add a test that catches the original error. Thanks [1] http://orgmode.org/worg/org-contribute.html -- Kyle