From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [bug] org-cycle changed behavior in orgstruct-mode Date: Sun, 30 Aug 2015 21:56:02 +0200 Message-ID: <874mjg360d.fsf@nicolasgoaziou.fr> References: <87fv3q2lxs.fsf@gmx.us> <878u9ic8sv.fsf@nicolasgoaziou.fr> <87zj1y0zst.fsf@gmx.us> <87614l95p7.fsf@nicolasgoaziou.fr> <877fodpzn0.fsf@gmx.us> <8737z145bo.fsf@nicolasgoaziou.fr> <87vbbwbpro.fsf@gmx.us> <87egik37dq.fsf@nicolasgoaziou.fr> <87io7wbm71.fsf@gmx.us> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43486) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZW8gL-0006Kn-6f for emacs-orgmode@gnu.org; Sun, 30 Aug 2015 15:54:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZW8gK-0008Ec-CB for emacs-orgmode@gnu.org; Sun, 30 Aug 2015 15:54:25 -0400 Received: from relay4-d.mail.gandi.net ([2001:4b98:c:538::196]:33724) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZW8gK-0008EU-4f for emacs-orgmode@gnu.org; Sun, 30 Aug 2015 15:54:24 -0400 In-Reply-To: <87io7wbm71.fsf@gmx.us> (rasmus@gmx.us's message of "Sun, 30 Aug 2015 21:39:14 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Rasmus Cc: emacs-orgmode@gnu.org Rasmus writes: > But are the slowdowns associated with outline.el functions anything that > will realistically be felt in normal usage? They are noticeable under certain circumstances. I implemented `org-show-children' because `show-children' was /reported/ as slow. Generally speaking, outline doesn't cope well with dense sub-trees. As an example, consider `org-forward-heading-same-level'. Using outline, we need to move to next headline, check its level, compare with original, rinse and repeat, possibly many times, until we find a match. However, we could simply do (re-search-forward some-appropriate-regexp nil t) and be done with it since we can turn level into a regexp. > IMO the biggest advantage of orgstruct is that it has more sensible > keybindings than outline. Of course it's also nice with lists and tables > (assuming they are not in orgstruct++; don't remember)... Table is orgtbl-mode, not orgstruct-mode. List handling is a real concern however, because we cannot use the parser (there is no context to know about) but still have to analyze lists. > Adding advice to orgstruct, which is a mess anyway, won't make it any > worse than it is... Agreed. > I'm all for advising if that's easier or if we want to add workarounds in > more places. For my problem, the proposed one line patch fixes it, > though. Indeed. But it only solves `org-show-children'. I have the feeling that we will encounter a similar issue with another base function like this one later, tho. Regards,