From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Thomas Preindl <thomas.preindl@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Org campture recursively expands %-escapes
Date: Thu, 26 Nov 2015 13:54:18 +0100 [thread overview]
Message-ID: <874mgb9gqv.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CA+iiQwTLDwpR-ypFitnpe7kKy8Kc0gdx1sixjRn39Vcuzzruxg@mail.gmail.com> (Thomas Preindl's message of "Sat, 21 Nov 2015 22:06:16 +0000")
Hello,
Thomas Preindl <thomas.preindl@gmail.com> writes:
> setting up my capture templates to work with a new Chrome extension I
> noticed that when i mark some text containing %-escapes inserted with the
> '%i' in the template the %-escape was
> evaluated.
>
> For example, marking %(print (buffer-name)) will be replaced with
> "*Capture*".
>
> I am now wondering if this is intended or not and if this could be
> used as a kind of exploit to run code if someone captures code
> from a website.
Judging from `org-capture-fill-template', this is a feature. Worse,
%(...) placeholders, the most dangerous ones, are always expanded last.
I guess the intent is to fill the Sexp with previous placeholders and
then eval it for a proper result (see, e.g., `org-capture-template's
docstring).
One solution would be to expand recursively Sexp placeholders at the
beginning of `org-capture-fill-template', right after expanding
properties placeholders (i.e., %:property), so as to limit the problem.
We could also remove recursivity for placeholders altogether. It is
buggy anyway (e.g., if a property placeholder introduces another
placeholder, the latter is not expanded).
Question to the ML: is there anyone relying on placeholder recursion?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2015-11-26 12:52 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-21 22:06 Org campture recursively expands %-escapes Thomas Preindl
2015-11-26 12:54 ` Nicolas Goaziou [this message]
2015-11-26 18:52 ` Samuel Wales
2015-11-26 22:02 ` Nicolas Goaziou
2015-11-26 22:10 ` Samuel Wales
2015-11-26 23:02 ` Nicolas Goaziou
2015-11-29 16:00 ` Nicolas Goaziou
2016-01-03 11:44 ` Michael Brand
2016-01-03 19:51 ` Nicolas Goaziou
2016-01-03 20:39 ` Michael Brand
2016-01-03 21:07 ` Nicolas Goaziou
2016-01-04 1:52 ` Michael Brand
2016-01-05 23:39 ` Nicolas Goaziou
2016-01-06 5:45 ` Michael Brand
2016-01-07 16:35 ` Nicolas Goaziou
2016-01-08 20:59 ` Michael Brand
2016-01-08 22:44 ` Nicolas Goaziou
2016-01-09 15:53 ` Michael Brand
2016-01-09 16:05 ` Nicolas Goaziou
2016-01-09 16:31 ` Michael Brand
2016-01-09 17:54 ` Nicolas Goaziou
2016-01-10 8:08 ` Michael Brand
2016-01-11 23:05 ` Nicolas Goaziou
2016-01-12 7:30 ` Michael Brand
2016-01-12 8:42 ` Nicolas Goaziou
2016-01-13 7:21 ` Michael Brand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874mgb9gqv.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=thomas.preindl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).