emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Adam Porter <adam@alphapapa.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: Is there a way to get all agenda TODOs programmatically?
Date: Wed, 03 Jan 2018 15:15:49 +0100	[thread overview]
Message-ID: <874lo3f2p6.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87po6rt76o.fsf@alphapapa.net> (Adam Porter's message of "Wed, 03 Jan 2018 07:15:11 -0600")

Hello,

Adam Porter <adam@alphapapa.net> writes:

> I have some more code you might find useful.  I had an idea to take a
> different approach with my org-agenda-ng code (not using org-element to
> parse the whole buffer first), and it seems to be working well so far.

Clearly, `org-element-parse-buffer' is not adequate for the task. When
buildings the agenda view, you're most probably interested in very
specific parts of the document, whereas Element tries to be as thorough
as possible.

I suggest even to not use any org-element-* function there.

> The code is here:
>
> https://github.com/alphapapa/org-agenda-ng/tree/non-element-parsing
>
> The code doesn't generate an identical result to the org-agenda code
> (not yet, anyway), but it's very similar.  It lacks the agenda prefix
> feature and full application of agenda faces (it does do a few faces
> already).  Most, if not all, text properties are applied.  And of
> course, more work could be done to make it look more like an official
> agenda buffer.

I don't want to sound offending, but your 400 locs library cannot
possibly be "very similar" to 10k locs org-agenda.el. Also, after
a cursory look, it is not clear how you solve the multi-days issue.
I.e., AFAIU, you still run multiple checks on the same entry.

Nevertheless, I think your approach is right. I think that, at some
point, we'll need to rewrite "org-agenda.el" from scratch, like we did
for "org-export.el" a few years back, so it becomes manageable again. In
the process, we definitely need to find a better replacement for
`org-agenda-skip', as done in your library.

So, in a nutshell, I think you're doing a step in the right direction.
I hope Org can ultimately benefit from a better "org-agenda.el".

My 2 cents,

Regards,

-- 
Nicolas Goaziou

  reply	other threads:[~2018-01-03 14:15 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-07  4:43 Is there a way to get all agenda TODOs programmatically? Marcin Borkowski
2017-10-07 14:20 ` Matt Lundin
2017-10-07 16:43   ` Marcin Borkowski
2017-10-07 16:54     ` Matt Lundin
2017-12-29 19:55       ` Marcin Borkowski
2017-12-31 23:37         ` Adam Porter
2018-01-03  9:31           ` Marcin Borkowski
2018-01-03  9:50             ` Adam Porter
2018-01-03 13:15               ` Adam Porter
2018-01-03 14:15                 ` Nicolas Goaziou [this message]
2018-01-03 15:48                   ` Adam Porter
2018-01-03 14:19                 ` Adam Porter
2018-01-03 13:49               ` Nicolas Goaziou
2018-01-03 14:16                 ` Adam Porter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874lo3f2p6.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=adam@alphapapa.net \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).