From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [PATCH] migrate ob-clojure initiate session code from ob-clojure-literate.el into ob-clojure.el Date: Wed, 24 Oct 2018 13:41:49 +0200 Message-ID: <874ldby3k2.fsf@nicolasgoaziou.fr> References: <87a7tza42f.fsf@gmail.com> <87o9iegsn7.fsf@nicolasgoaziou.fr> <877ei8uaz1.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:48561) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gFHXz-0007TG-Kl for emacs-orgmode@gnu.org; Wed, 24 Oct 2018 07:42:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gFHXv-00078T-Hx for emacs-orgmode@gnu.org; Wed, 24 Oct 2018 07:41:59 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:58699) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gFHXt-000766-IJ for emacs-orgmode@gnu.org; Wed, 24 Oct 2018 07:41:55 -0400 In-Reply-To: <877ei8uaz1.fsf@gmail.com> (stardiviner's message of "Tue, 23 Oct 2018 20:02:58 +0800") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: stardiviner Cc: org-mode Hello, stardiviner writes: > Nicolas Goaziou writes: > > Hi, sorry for late response, because I'm a little lazy on give effort on > review my patch and improve it again. But now I finished it. Actually I > corrected my patch as soon as you replied email with mentioned. Today I > pick up this task again, and add a new improve which support CIDER new > API which using sesman to manage REPL sessions. OK. So does it qualify as a bug fix, i.e., should that go into master branch, or is it a new feature, for next branch? BTW, there are some compilation warning: --8<---------------cut here---------------start------------->8--- Compiling /home/ngz/dev/org-mode/lisp/ob-clojure.el... In toplevel form: ob-clojure.el:215:1:Warning: Unused lexical variable =E2=80=98sesman-system= =E2=80=99 In org-babel-clojure-initiate-session: ob-clojure.el:225:47:Warning: reference to free variable =E2=80=98cider-ver= sion=E2=80=99 In end of data: ob-clojure.el:278:1:Warning: the function =E2=80=98cider-repls=E2=80=99 is = not known to be defined. --8<---------------cut here---------------end--------------->8--- Could you fix them? Thank you. Regards, --=20 Nicolas Goaziou