From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: stardiviner <numbchild@gmail.com>
Cc: org-mode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] migrate ob-clojure initiate session code from ob-clojure-literate.el into ob-clojure.el
Date: Wed, 24 Oct 2018 13:41:49 +0200 [thread overview]
Message-ID: <874ldby3k2.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <877ei8uaz1.fsf@gmail.com> (stardiviner's message of "Tue, 23 Oct 2018 20:02:58 +0800")
Hello,
stardiviner <numbchild@gmail.com> writes:
> Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
>
> Hi, sorry for late response, because I'm a little lazy on give effort on
> review my patch and improve it again. But now I finished it. Actually I
> corrected my patch as soon as you replied email with mentioned. Today I
> pick up this task again, and add a new improve which support CIDER new
> API which using sesman to manage REPL sessions.
OK. So does it qualify as a bug fix, i.e., should that go into master
branch, or is it a new feature, for next branch?
BTW, there are some compilation warning:
--8<---------------cut here---------------start------------->8---
Compiling /home/ngz/dev/org-mode/lisp/ob-clojure.el...
In toplevel form:
ob-clojure.el:215:1:Warning: Unused lexical variable ‘sesman-system’
In org-babel-clojure-initiate-session:
ob-clojure.el:225:47:Warning: reference to free variable ‘cider-version’
In end of data:
ob-clojure.el:278:1:Warning: the function ‘cider-repls’ is not known to be
defined.
--8<---------------cut here---------------end--------------->8---
Could you fix them?
Thank you.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2018-10-24 11:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-19 10:22 [PATCH] migrate ob-clojure initiate session code from ob-clojure-literate.el into ob-clojure.el stardiviner
2018-04-20 8:59 ` Nicolas Goaziou
2018-10-23 12:02 ` stardiviner
2018-10-24 11:41 ` Nicolas Goaziou [this message]
2018-10-25 5:51 ` stardiviner
2018-10-25 8:37 ` Nicolas Goaziou
2018-10-25 23:38 ` stardiviner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874ldby3k2.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=numbchild@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).