From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Carlos Pita <carlosjosepita@gmail.com>
Cc: emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Faulty logic in org-cmp-tag/alpha
Date: Sun, 10 Mar 2019 11:15:50 +0100 [thread overview]
Message-ID: <874l8bjaqx.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CAELgYhcWzkvzmoEjGk-MmtLrSRGbPoR9HqTf-dpo3KZ9DkXsUg@mail.gmail.com> (Carlos Pita's message of "Sat, 9 Mar 2019 17:55:41 -0300")
Hello,
Carlos Pita <carlosjosepita@gmail.com> writes:
> Hi all,
>
> there is a problem in this kind of logic:
>
> (cond ((not ta) +1)
> ((not tb) -1)
> ((string-lessp ta tb) -1)
> ((string-lessp tb ta) +1))))
>
> in that when both ta and tb are nil then they are arbitrarily sorted.
> Since the agenda sorting strategy is lexicographic this logic
> virtually invalidates any strategy that puts tag or alpha first, v.g.
> '(tag-up priority-down).
>
> I've attached a patch returning nil when both ta and tb are nil so as
> to fallback to the next sorting criterion without favoring lhs nor
> rhs.
Applied. Thank you.
Regards,
--
Nicolas Goaziou
prev parent reply other threads:[~2019-03-10 10:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-09 20:55 [PATCH] Faulty logic in org-cmp-tag/alpha Carlos Pita
2019-03-10 10:15 ` Nicolas Goaziou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874l8bjaqx.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=carlosjosepita@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).