emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: Tom Gillespie <tgbugs@gmail.com>
Cc: emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] ob-core: Fix handling of multiple noweb refs in same line
Date: Tue, 15 Sep 2020 23:50:10 -0400	[thread overview]
Message-ID: <874kny753h.fsf@kyleam.com> (raw)
In-Reply-To: <CA+G3_PMiu3TtYVGnf0ebV-vjjrJxv2W-2YJabBi+pweFZDPBrw@mail.gmail.com>

Tom Gillespie writes:

>    This fixes the issue on my system, and looking over the bisected
> commit it looks like the ^ was just an oversight. This also resolves
> the issue for <<references()>> as well, I don't think we need a
> separate test case for that since any issue with references breaking
> should show up elsewhere (though I guess you never know). Thank you
> for tracking this down, and now I know how to add ert tests for things
> like this in the future! Best,
> Tom
>
> On Tue, Sep 15, 2020 at 12:21 AM Kyle Meyer <kyle@kyleam.com> wrote:
[...]
>> Subject: [PATCH] ob-core: Fix handling of multiple noweb refs in same line

Thanks for testing on your end.  Pushed (469ee6340).


  reply	other threads:[~2020-09-16  3:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-14 18:56 Bug: org-babel only tangles first noweb reference on a line [9.4 (9.4-elpaplus @ /home/tom/.emacs.d/elpa/org-plus-contrib-20200914/)] Tom Gillespie
2020-09-15  4:20 ` [PATCH] ob-core: Fix handling of multiple noweb refs in same line Kyle Meyer
2020-09-15  4:52   ` Tom Gillespie
2020-09-16  3:50     ` Kyle Meyer [this message]
2021-04-27 19:36 ` Bug: org-babel only tangles first noweb reference on a line [9.4 (9.4-elpaplus @ /home/tom/.emacs.d/elpa/org-plus-contrib-20200914/)] Bastien
2021-04-27 21:18   ` Kyle Meyer
2021-04-28  3:35     ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874kny753h.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=tgbugs@gmail.com \
    --subject='Re: [PATCH] ob-core: Fix handling of multiple noweb refs in same line' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).