From: Kyle Meyer <email@example.com> To: Maxim Nikulin <firstname.lastname@example.org> Cc: email@example.com Subject: Re: greedy substitution in org-open-file Date: Fri, 12 Feb 2021 02:16:40 -0500 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <email@example.com> Maxim Nikulin writes: > Looking into the code related to 'pty problem with > start-process-shell-command, I have realized that the following case is > not handled correctly: > > #+begin_src elisp > (setq org-file-apps '(("\\.pdf::\\([0-9]+\\)\\'" . "xpdf %s %1"))) > #+end_src Not relevant for the underlying issue, but doesn't xpdf require a colon before the page number (i.e. ":%1")? > I hope, I adapted an example from [[help:org-file-apps]] correctly. When > I try to open the following link using C-c C-o > > [[file:test-%1f.pdf::42]] > > I get > > Running xpdf /home/ubuntu/examples/org/test-\42f.pdf 42...done > > I believe, it should be > > Running xpdf /home/ubuntu/examples/org/test-%1f.pdf 42...done > > Or > > Running xpdf /home/ubuntu/examples/org/test-\%1f.pdf 42...done Yep, it should show up as "Running xpdf /tmp/test-\%1f.pdf :42...done", with the backslash coming from shell-quote-argument. > The source of the problem is that %s substitution is expanded at first > and regexp groups are replaced later. Ideally, it should be performed in > a single pass. I have found format-spec function but I am unsure > concerning it, maybe it is avoided intentionally. I believe format-spec requires the placeholder to be A-z: (format-spec "xpdf %s" '((?s . "a"))) => "xpdf a" (format-spec "xpdf %s %1" '((?s . "a") (?1 . "b"))) ;; Invalid format string What about flipping the processing, handling the %N placeholders first and then formatting the file name? Seems to work on my end, though I haven't tested it thoroughly. diff --git a/lisp/org.el b/lisp/org.el index c61b8fb56..31dbe352a 100644 --- a/lisp/org.el +++ b/lisp/org.el @@ -8714,12 +8714,6 @@ (defun org-open-file (path &optional in-emacs line search) ;; Remove quotes around the file name - we'll use shell-quote-argument. (while (string-match "['\"]%s['\"]" cmd) (setq cmd (replace-match "%s" t t cmd))) - (setq cmd (replace-regexp-in-string - "%s" - (shell-quote-argument (convert-standard-filename file)) - cmd - nil t)) - ;; Replace "%1", "%2" etc. in command with group matches from regex (save-match-data (let ((match-index 1) @@ -8731,7 +8725,11 @@ (defun org-open-file (path &optional in-emacs line search) (while (string-match regex cmd) (setq cmd (replace-match replace-with t t cmd)))) (setq match-index (+ match-index 1))))) - + (setq cmd (replace-regexp-in-string + "%s" + (shell-quote-argument (convert-standard-filename file)) + cmd + nil t)) (save-window-excursion (message "Running %s...done" cmd) (start-process-shell-command cmd nil cmd)
next prev parent reply other threads:[~2021-02-12 7:17 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-20 16:08 Maxim Nikulin 2021-02-12 7:16 ` Kyle Meyer [this message] 2021-02-12 16:46 ` Maxim Nikulin 2021-02-13 4:38 ` Kyle Meyer 2021-02-15 17:04 ` Maxim Nikulin 2021-03-03 12:47 ` Maxim Nikulin 2021-03-21 12:36 ` Maxim Nikulin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: greedy substitution in org-open-file' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).