From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id YDOSDEI4WWErJgEAgWs5BA (envelope-from ) for ; Sun, 03 Oct 2021 06:57:38 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id ID07CEI4WWH/SwAA1q6Kng (envelope-from ) for ; Sun, 03 Oct 2021 04:57:38 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A8B7A9205 for ; Sun, 3 Oct 2021 06:57:37 +0200 (CEST) Received: from localhost ([::1]:54178 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mWtZ9-0006cl-Mn for larch@yhetil.org; Sun, 03 Oct 2021 00:57:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51714) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mWtYm-0006bn-3W for emacs-orgmode@gnu.org; Sun, 03 Oct 2021 00:57:12 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40534) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mWtYl-0006pF-Rg; Sun, 03 Oct 2021 00:57:11 -0400 Received: from [2a01:e34:ec2b:7150:65fa:1638:bd2b:fd22] (port=33322 helo=hal) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mWtYl-0001H8-Ho; Sun, 03 Oct 2021 00:57:11 -0400 Received: by hal (Postfix, from userid 1000) id AFC191E0420; Sun, 3 Oct 2021 06:57:09 +0200 (CEST) From: Bastien To: Timothy Subject: Re: [PATCH] Prevent displayed images from being re-scaled In-Reply-To: <87bl4bcxe3.fsf@gmail.com> (Timothy's message of "Wed, 29 Sep 2021 21:33:34 +0800") Organization: GNU References: <87bl4bcxe3.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.60 (gnu/linux) Date: Sun, 03 Oct 2021 06:57:09 +0200 Message-ID: <874k9y7lju.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Org-Mode Mailing List Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1633237057; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=dLaJFyRxsqMb4vsVXYmNtTmSnAGhVlAcqW748SNFRNk=; b=ERuPxgLOIaFrsTblO6YgOue0Je9klRbElznzj4RsS2BrQJuVDhWaPLF0AI4BOmeSiA0xgx Q248VqiP+zWYJkG2PsKPF/0kgyV1Ft/bOWkVcEDvkhmSkeJfRg7MeVD3X01/k9Dd84dqig l3SRsyrnCKE6fOO4pub4uLQtwBJgqi3Bx6H1HCIiUUxCf3JFO0GJMlPm8dOTgKSdXeeAp+ Dmvk8JFTBkcP5/A6i/y787Ls2j/T3TT4HNjJFuwPW5nFR9iNBNFSuW35WWPJ97kiFuTehF bbfIjZG9KySHJKXuF/tf9iaoNUQs3pdiy5XNoJOCFZEtznCAXTCrZZk5aD6qIA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1633237057; a=rsa-sha256; cv=none; b=UtoGzYAXXNZb96qr36fvdHvukmN8dKBDw3t3fMXIMb67FSaYGz/yGq6VF0QYRYVxkoEWsH 7AtHcdTax7AMr3R1NrHdqOXtAxHVsHP7p9ukNkM0ffmoVYg5i//ARbKvCchWX7MPnlwkqo NiYIIbpsfRSdoLxt+B8dCPhdSiHAEFaVVoC6aYajo8BidoS81FduEdPE1+hyG0/zqdUTSa necJZdnLJt3G/Fzz6nxyCZxMCivADrOihkobAs1kGCjyzeZzVgBWQ1tFnxQG0vewImrNcf 37JmCVH3ZEG9/uNX/kYALkbvj9z+V7teAjGyZ//sCN9wreFUHIXFOVsEFiPImQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -3.50 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: A8B7A9205 X-Spam-Score: -3.50 X-Migadu-Scanner: scn1.migadu.com X-TUID: OpU4DXNKnBBF Hi Timothy, Timothy writes: > From 9c34dd6aba62d734f6ae9aecaffa76a0250bf495 Mon Sep 17 00:00:00 2001 > From: TEC > Date: Wed, 29 Sep 2021 21:29:27 +0800 > Subject: [PATCH] org: Don't change image size based on font size > > * lisp/org.el (org--create-inline-image): When `create-image' is called > without the :scale parameter, the image size is expanded based on the > default font size (if it is larger than 10px). When displaying images > with a specified width in Org buffers, either in pixels or proportional > to the text width, this width should not be modified according the to > font size. Giving a :scale parameter of 1 prevents this font-size based > rescaling. Nitpick: I suggest shortening the ChangeLog part like this: * lisp/org.el (org--create-inline-image): Set :scale parameter to 1 to prevent font-size based rescaling. When `create-image' is called without the :scale parameter, the image size is expanded based on the default font size (if it is larger than 10px). When displaying images with a specified width in Org buffers, either in pixels or proportional to the text width, this width should not be modified according the to font size. Giving a :scale parameter of 1 prevents this font-size based rescaling. The ChangeLog part should not be too verbose, you can add explanations after it. Thanks, -- Bastien