From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id kKbfGyIZO2L+MgEAgWs5BA (envelope-from ) for ; Wed, 23 Mar 2022 13:57:06 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id UMwkGSIZO2K9dgEA9RJhRA (envelope-from ) for ; Wed, 23 Mar 2022 13:57:06 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F40BB118B2 for ; Wed, 23 Mar 2022 13:57:05 +0100 (CET) Received: from localhost ([::1]:52656 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nX0Xx-0006YD-02 for larch@yhetil.org; Wed, 23 Mar 2022 08:57:05 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51278) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nWzzZ-0004Nl-HS for emacs-orgmode@gnu.org; Wed, 23 Mar 2022 08:21:33 -0400 Received: from [2607:f8b0:4864:20::631] (port=39889 helo=mail-pl1-x631.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nWzzX-0006xt-GZ for emacs-orgmode@gnu.org; Wed, 23 Mar 2022 08:21:33 -0400 Received: by mail-pl1-x631.google.com with SMTP id g3so1351375plo.6 for ; Wed, 23 Mar 2022 05:21:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=V42QzFRu9GD5YWCzP68uz27nhhH8nZ8axSMAFrCNVjc=; b=aWFqMsB51vfDq71vJpZBy08d3GXgeS/UDezpqpw5FOHN+tbrr0zMkzQTtT2NUVUJKN VBQzMqy9RXL+WsxJwFOrAlwDauBrZPlUHyAu10K9aaky5iZ1Q5fqbrrPZqIz4s54+mF2 MOfIT1n//D1Km1plD1OeJ/ccHD6xDtUe5ATx5z8hEisfHvLBl4Ufv2TqbuSxQoj0ufeu 18aOUUmwUbjcO+yAI3U95BYK2ADvMlV3XfYVZHfQ/nA7hWYjcYHAJEl1oxbzhZ1CU1N1 O1X5+FZF8wRodYTeJMpgTAeAUBIwVRG83jC1AnbP8mk/GM7bLB6oVxVllPp+FJ34guAe oL4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=V42QzFRu9GD5YWCzP68uz27nhhH8nZ8axSMAFrCNVjc=; b=SagOmMTFD1Dmu6P71dGVeg0KwxL2xiXwUdlK3YSYuqwhdTFsCRZNIUH1SgFuNA5Cfw vdmAqx1a/fmlWyUt/EVgWHSG70t//de9mVQ9CUr5VwTzVi96nxFjPvFK25bw4Pfc22E1 xjFjJWe5kIlspIBH+Fdudw1ZhuncrIBKVlGLGfjCLDIzuXW3ybngoKsfbVpXbs232j/5 eCdZ6Kr4BbgjUgSMLYyYcizTlYP9aGrZ3T5qi3e0FfHOTpr1VAyIL/ySD+sJJUXmFbzs aRLQWh7heNpz5DtNSZBUxFMBZwJv/SN4KAXN4f0kiL22PJ2aDfnCoHhK759oLQDwY7gk 6uvA== X-Gm-Message-State: AOAM531l2vBdT/jOzaUmFDS718GDdBwpXvTbWH4sK0Pgytxwr6CeY84N Dn/e8GhOf0Ob9URYV18tbyU= X-Google-Smtp-Source: ABdhPJySS9fQvmPWHvkTDsnMVKvBcV6N4nV00mEK7ro78VYPaAs6IMbGOGqrgB1RkGYZMADchqxs9A== X-Received: by 2002:a17:902:9008:b0:14f:b1f9:5271 with SMTP id a8-20020a170902900800b0014fb1f95271mr22655759plp.86.1648038089961; Wed, 23 Mar 2022 05:21:29 -0700 (PDT) Received: from localhost ([209.95.60.92]) by smtp.gmail.com with ESMTPSA id il7-20020a17090b164700b001c779d50699sm3418216pjb.55.2022.03.23.05.21.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Mar 2022 05:21:29 -0700 (PDT) From: Ihor Radchenko To: Samuel Wales Subject: Re: [BUG] Agenda no longer works for timestamps inside properties drawer [9.5.2 (release_9.5.2-24-g668205 @ /home/ignacio/repos/emacs/lisp/org/)] In-Reply-To: References: <87v8wje4nd.fsf@localhost> <066001d83d3c$7b463380$71d29a80$@tomdavey.com> <87lex2mgtw.fsf@localhost> Date: Wed, 23 Mar 2022 20:21:51 +0800 Message-ID: <874k3ouae8.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::631 (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::631; envelope-from=yantar92@gmail.com; helo=mail-pl1-x631.google.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ignacio Casso , emacs-orgmode@gnu.org, tom@tomdavey.com Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1648040226; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=V42QzFRu9GD5YWCzP68uz27nhhH8nZ8axSMAFrCNVjc=; b=loIAKB/1ALmAv4s7u/C+lnREW9QcvqvIzs5K9uRpfrAUAIOTLnZcRdznTiGfoOSiFBuQ4X DFdbw9UYTK3gX1ejik+Bk8yEcyYMFlmdkcY//lmPZwhyzAbzVofD5JEY4tpaLZ7rgwpmeU GkyLEcwe8WBcWiuroNJKibDd+w4zRZlBCyPj3t55qVT9bRPoi9h40NYP4OhOtHezx6ZipK RjkFbiDBgh2TdtEM9Ro2xNaFc/VzY7Jb9IoQ7/bHWjsCGMFC/RfS3PtrsCwMKVhgjEt3Yb Hr50jJPu9xwJIFHRmiR+NRRQxRrfyFmN8eTU0OcTOPdtd1k9ss7N0dtNbdaloA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1648040226; a=rsa-sha256; cv=none; b=D6WGt/CjJFTWR+3AFg4N5r/jDEu+d7reIw+W9YBQd1Gk1hwxXuxUIwd55Q2SwyJ+5YOxIu T8GUczb+WGPbCDPzLsqxgTVQfv1BEw1zhuUgCrCa66jCyVZyjcfAYgE9SYe86CMVq48McI aQr8st0Zm9XaLqkmGAJQcr7V7haHVZCMBLyqywsgDotoIcfU92IjSHnsie9yEKMgbu6g2s j1f/ISzRZAJ+7Kf9MsVUbcYppL9dGJ/ahLRP3RyaLJRJq2iBKcdsI65XxOCuz77t08psca HLzxdzhenAxFWgC633CWlt599RC9cJ5p2lLAqZgWQzJ8yIup0mwbn4xLoR2giw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=aWFqMsB5; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 6.10 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=aWFqMsB5; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: F40BB118B2 X-Spam-Score: 6.10 X-Migadu-Scanner: scn0.migadu.com X-TUID: KFZfh5v227tj Samuel Wales writes: > your idea of expanding to other date-like things is an interesting > idea, and so is making an analogy with log mode. > > another possibility is to satisfy the preferences users have expressed > [and those with n>1 needs] using a single variable that contains the > contexts that should show in daily/weekly agenda. org uses multi-item > variables more frequently in recent years [e.g. > org-show-context-detail or visibility for sparse trees] which reduces > vars. you might have had log mode items in mind, which is similar. Your idea about multi-term variables reminds me about org-agenda-log-mode-items. So, the proposed broad matching of anything time stamp-like under headlines might be a new option in that variable: org-agenda-log-mode-items is a variable defined in org-agenda.el. Documentation List of items that should be shown in agenda log mode. This list may contain the following symbols: closed Show entries that have been closed on that day. clock Show entries that have received clocked time on that day. state Show all logged state changes. Note that instead of changing this variable, you can also press C-u l in the agenda to display all available LOG items temporarily. > [one problem now being that users can be not merely surprised, but > unaware that stuff is missing from agenda.] To clarify, this bug report came after another commit I introduced. That commit fixed a user complaint that it was literally impossible to prevent headlines from being shown in agenda when, for example, a timestamp was inside a code block or quote block. https://orgmode.org/list/20220101122409.GA29829@itccanarias.org So, in the past, agenda showed every headline containing matching active (or inactive, if inactive timestamps where set to be included in agenda) timestamp anywhere under headline regardless of the context. I changed that, causing the bug report here. Now, I fixed the regression noticing that agenda views where intended to catch timestamps inside property drawers according to (org-at-timestamp-p 'agenda) The current fix did not restore the initial behaviour of including every possible timestamp regardless of the context, but that behaviour appears to be unintentional given the docstring of org-at-timestamp-p: Non-nil if point is inside a timestamp. By default, the function only consider syntactically valid active timestamps. However, the caller may have a broader definition for timestamps. As a consequence, optional argument EXTENDED can be set to the following values ... agenda Include timestamps allowed in Agenda, i.e., those in properties drawers, planning lines and clock lines. > another context [not to create controversy but also for in principle > orthogonality] is line comments, which some think should mean tses and > links therein should not show up in agenda and not fontify and not be > clickable [rule = "remove tses and links from org semantics and > fontification including agenda but not including certain org searchers > like org-occur-in-agend-files"], while others think should mean > "remove from all export" [use case: so you as author can document > exportable stuff inline using comments and still have your tses show > up in daily/weekly if you want that and have clickable links without > having those exposed to the recipient of the exported document, etc.]. > links in line comments can be worked around with a bit of code, but > idk about tses. some will want tses commentable. some not. > Could you elaborate? Maybe provide an example. Best, Ihor