From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id yAR3JQxod2Ik5QAAbAwnHQ (envelope-from ) for ; Sun, 08 May 2022 08:49:48 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id sOilJQxod2L1dwAA9RJhRA (envelope-from ) for ; Sun, 08 May 2022 08:49:48 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2F35445B05 for ; Sun, 8 May 2022 08:49:48 +0200 (CEST) Received: from localhost ([::1]:37788 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nnaji-0001Yl-TE for larch@yhetil.org; Sun, 08 May 2022 02:49:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48440) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nnaiI-0001Xz-NU for emacs-orgmode@gnu.org; Sun, 08 May 2022 02:48:20 -0400 Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]:40955) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nnaiG-0002y6-Lv for emacs-orgmode@gnu.org; Sun, 08 May 2022 02:48:17 -0400 Received: by mail-pj1-x1031.google.com with SMTP id iq2-20020a17090afb4200b001d93cf33ae9so14403358pjb.5 for ; Sat, 07 May 2022 23:48:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=x+ZajwxmtlTjUHjRG2cZvIngL4pF6NsECX9Ii4gAVHs=; b=gfEEvG3hZ/K5phVFM6OGqqTPtHL4g1mFrkMcZk02Hokv/kR3h5aK8NsxyHP8ed2Bnk tb0p0Eelket+cqhktE4WQMaa8q24GOIMKZPRplRIQ01O682d74r6O51Q81WmDUQaiYyg f0wRbpZgkV9zuG4RG9+RC5ucbHGJ30jND942xa4B1935YvYL1VVL+R+ViVnfDNz86ay8 7vsmMYG5c+QsPnzhCv+xRYwZlhr3tbYZhLajo3V21QFuiLKYRnUocP/YTChqBQEekABy PbQNSWmhzySdOofaNbnBGul2cRLmtSN46JF9IGQ3fFO1cRWDlPvn/s0JeoKBt59w7PdX 31QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=x+ZajwxmtlTjUHjRG2cZvIngL4pF6NsECX9Ii4gAVHs=; b=N0rGsqdTEXQ6cOW4wnBp+TZLcFdDw8Uplw49yYzfhq9ZFp5VoE7FCrCVx3ZZ4mkvWa OFteN6QoJwtL0TS4n2hOYXobrCBZfarHW8oF1aHyiBR5GmJZde7tCS6QWPxoxoCAPn6I yMuewvGPJ4yte73DIWwuh0JyU1Q4rt/XISv/OSC4YQa41vJSIZptM6zYBJDpO0iZA+Kx 8VaB3YWHQe9SS38bLv7l9yE4WnXF+epBfgRykJqFC1BEm695Egrk1PqEyROpQQxbNVOv bVSCgrJGpIZ0oRCwMDCRxfUtVKLWkFpAUJf8FecvRVoSqMCWX66cDSZOG9DKpRJvUsqA rPrg== X-Gm-Message-State: AOAM5318NkAzZjiIpN7OvoMcPmlfIOZ8Q7LwI7gxh/lwmtnosLDJcMDe EEf2qLzKL2wDTS1HZa2UtHk= X-Google-Smtp-Source: ABdhPJzkjKUofMO4jaJhGM1pn+j8j/FFlLWE0ZvO/wVn6T5mnWLhyjFO7Xdx4Tvudjbh+aiZ9syaSQ== X-Received: by 2002:a17:902:bb8d:b0:156:51a1:3f5a with SMTP id m13-20020a170902bb8d00b0015651a13f5amr10902920pls.65.1651992494912; Sat, 07 May 2022 23:48:14 -0700 (PDT) Received: from localhost ([66.154.104.4]) by smtp.gmail.com with ESMTPSA id k2-20020a170902ba8200b0015e8d4eb204sm4614835pls.78.2022.05.07.23.48.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 May 2022 23:48:14 -0700 (PDT) From: Ihor Radchenko To: Max Nikulin Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] ob-plantuml: Allow setting PlantUML args for jar file In-Reply-To: References: <5d7eba13-b717-a12a-5f89-7d2c9414917e@gmail.com> <87y23hr045.fsf@localhost> <1a42304e-47b6-48c3-01b4-6d858ddf7770@gmail.com> <87lezdnpcp.fsf@localhost> <87mtjpz22t.fsf@localhost> Date: Sun, 08 May 2022 14:48:57 +0800 Message-ID: <874k20v7s6.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::1031; envelope-from=yantar92@gmail.com; helo=mail-pj1-x1031.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1651992588; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=x+ZajwxmtlTjUHjRG2cZvIngL4pF6NsECX9Ii4gAVHs=; b=FKgQlBPBt1FYqezTawWQkc2IO7fYhHY0B2SQHMpGWl8N9tl73kY35K2l1ENZJQz07mmToi P/bHw66TzSnvKnyOCzj0cOlvoq6CHZVEAF7U/lHxldpjYSdNxkf3q/UKZEHPpN8vnlOW2v 89yvuFiZStb6lukRjRZlETBFPv1u56SvGDHm+DSTOmGJnTiW2kNSAd51brREn0YNijgULv ynQGrTHbrlzpH4oA0j7GQvoK6yvyPY30nBujNN/eegFWe3kfeGFf5g3lEEA8knT0h1zewy ng61+FOJ5FNeZT0yJ8Ao4MuxMhMk+G97M0nseRAVzGlqVcB1229RYwLfPcUDMg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1651992588; a=rsa-sha256; cv=none; b=HPak/zj+351u3+EvyQHds/Fvmyp+rqcTlb6sS3FEvGIO88DYWCDX2UW7XqhWe5l4Fm8NUj DS3wkTQajS9DvTZd/cCUDg9n3XEQYUv3WQD3vzOvxXyX6gA/i3WiAIQmuX/gew8FRJNPAY q0tV0QXFqTHscF73xgGeFY3eBjzhL+ul1Xlxb1f7iNjUmEUPd3gMYfynOuP7DgqKOodJTy itP2/2obubcGK29Kb2pcF7Y89YrKnB8ik7pnEiHr0m0KRwuc8uxwT8Ttqp13kM7lWK3RoS DryhewRM8e/8jDY57v5PySyw9Hf1OYLOJd6rWYjbLFQXuykPudEmPJNIEVzm2Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=gfEEvG3h; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.50 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=gfEEvG3h; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 2F35445B05 X-Spam-Score: -3.50 X-Migadu-Scanner: scn1.migadu.com X-TUID: O/zpVqz7UosH Max Nikulin writes: > To wrap up, I suggest (and I do not insist) to drop > "-Djava.awt.headless=true" since "-headless" is anyway added in jar > mode. Those who desperately need namely "-Djava.awt.headless=true" (for > some unknown to me reason) may customize :java header argument. I do not > see any real problem with the change, just a minor improvement. After further consideration, I decided to follow your suggestion. If we insist of -Djava.awt.headless=true in org-plantuml-exec-mode='jar but not in 'plantuml, we may run into inconsistency between users using the two alternatives. Applied onto main as b5f0efc04. Best, Ihor