emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Ihor Radchenko <yantar92@gmail.com>
To: Max Nikulin <manikulin@gmail.com>
Cc: emacs-orgmode@gnu.org,  Hugo Heagren <hugo@heagren.com>
Subject: Re: [PATCH] org-test: Run all ol tests on make test
Date: Wed, 27 Jul 2022 11:49:44 +0800	[thread overview]
Message-ID: <874jz3b4fb.fsf@localhost> (raw)
In-Reply-To: <218fded4-485e-d34e-4f9e-68f4eff8ae81@gmail.com>

Max Nikulin <manikulin@gmail.com> writes:

> Hi,
>
> I figured out why "make test" is passing successfully while the same 
> with BTEST_RE="test-ol/insert-link-insert-description" is failing for a 
> proposed patch. Default selection pattern is ignoring most test-ol 
> cases. See the attachment.

Thanks a lot for narrowing this down!

> --- a/testing/org-test.el
> +++ b/testing/org-test.el
> @@ -424,7 +424,7 @@ setting `pp-escape-newlines' to nil manually."
>      "^\\([^.]\\|\\.\\([^.]\\|\\..\\)\\).*\\.org$")))
>  
>  (defun org-test-run-batch-tests (&optional org-test-selector)
> -  "Run all tests matching an optional regex which defaults to \"\\(org\\|ob\\)\".
> +  "Run all tests matching an optional regex which defaults to \"\\(org\\|ob\\|-ol\\)\".
>  Load all test files first."
>    (interactive)
>    (let ((org-id-track-globally t)

You missed the

	(org-test-selector
	 (if org-test-selector org-test-selector "\\(org\\|ob\\)"))

inside org-test-run-batch-tests

Also, org-test-run-all-tests

Best,
Ihor

next prev parent reply	other threads:[~2022-07-27  3:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-26 15:27 [PATCH] org-test: Run all ol tests on make test Max Nikulin
2022-07-27  3:49 ` Ihor Radchenko [this message]
2022-07-27 15:43   ` Max Nikulin
2022-07-28 14:31     ` Ihor Radchenko
2022-07-28 15:14       ` [PATCH v2] " Max Nikulin
2022-07-29 13:06         ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874jz3b4fb.fsf@localhost \
    --to=yantar92@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=hugo@heagren.com \
    --cc=manikulin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).