emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: Alex Giorev <alex.giorev@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] two small fixes for org-fast-tag-selection
Date: Sat, 29 Oct 2022 05:15:22 +0000	[thread overview]
Message-ID: <874jvnjjmd.fsf@localhost> (raw)
In-Reply-To: <CAMq3WZg4UUXruHVbv56bEAcGAbbvcAbAznQrBx_RbzetUZysSA@mail.gmail.com>

Thanks for the patches, and sorry for the late reply.

Alex Giorev <alex.giorev@gmail.com> writes:

> - The first patch fixes the problem of TODO keywords and tags sharing keys
> when they are automatically generated and when
> `org-fast-tag-selection-include-todo' is set.

Could you please show minimal examples that demonstrate the problem you
are trying to fix?

> - The problem solved by the second patch is the following: when invoking
> the fast selection interface, and pressing the key of a tag, the tag is
> highlighted to indicate it has been selected, but pressing the key again
> doesn't unhighlight it.

On my side, the tag does get unenlightened even without the patch (on
the latest main).

Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

      reply	other threads:[~2022-10-29  5:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-10 20:21 [PATCH] two small fixes for org-fast-tag-selection Alex Giorev
2022-10-29  5:15 ` Ihor Radchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874jvnjjmd.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=alex.giorev@gmail.com \
    --cc=emacs-orgmode@gnu.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).