From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id AGheJbgAl2OdHQEAbAwnHQ (envelope-from ) for ; Mon, 12 Dec 2022 11:21:44 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id aKVKJbgAl2MQbwEA9RJhRA (envelope-from ) for ; Mon, 12 Dec 2022 11:21:44 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4A17F25FDC for ; Mon, 12 Dec 2022 11:21:44 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p4fva-00072u-Ej; Mon, 12 Dec 2022 05:20:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4fvV-00072H-4U for emacs-orgmode@gnu.org; Mon, 12 Dec 2022 05:20:49 -0500 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4fvT-0007hB-De for emacs-orgmode@gnu.org; Mon, 12 Dec 2022 05:20:48 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 9E42A240026 for ; Mon, 12 Dec 2022 11:20:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1670840445; bh=tLdsdIpAvaFzCe99DIjZyW/wOTHXt+WXKGlWSyQ4e/s=; h=From:To:Cc:Subject:Date:From; b=BMNiuuDE48Jej0bzypplKxdDodfseH/L1JLS0qjnLHDtHrjE9xK10+5orFZcoyL7f vwBVR8gU9gx85X6Xfh9BcX8N39zVcQHQEb01UPSLeSNMpBHMrlnXsOxwca9SbvW8Of ak3iUFZ2RysOHC+i3EP6eMWOQk9zXsnowyUoim1HP+uD7cqXZerFc450IAjEz6MMnH 4E/r1XzLq50O6FSTudWyKLKsKDVEePipnGUvTWe9baq2K0+wofzLykLE60GMhHxxF+ CExInc1vfFXo7dbTZsgD8/h2hIpast2tmdsJjBGNAJtbx62OlmV6B97n5KPsUwOAgy rxUBp9iKTQGLg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NVyLz6ZVtz9rxN; Mon, 12 Dec 2022 11:20:43 +0100 (CET) From: Ihor Radchenko To: Tom Gillespie , Bastien Cc: Kyle Meyer , emacs-orgmode@gnu.org Subject: Re: [PATCH] ob-core: add org-confirm-babel-evaluate-cell custom variable In-Reply-To: References: <87359ld5ye.fsf@kyleam.com> Date: Mon, 12 Dec 2022 10:20:43 +0000 Message-ID: <874ju0j538.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1670840504; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=jEh4Zkm2K9MOARlCv4u+c9r7Z5XnuVweAPVgQ77tvPE=; b=r/tXr8UHu2pC2QH83HMLYAaUvYy7Oep2YK+/6L3bv3L6UaGgUVoaNCSWMpZZ33oaW8Ujfp CBUfAD1lEnFKcVcoZlZY3vFFliBS3RB7pgjkcgnJokQLwP3dS1amxWikdbLqpxX3+myqtJ +aYnNb8iN0N5kC7+7GACzRtthFwAMmaQDT8/jtzX3PUc5pLKRZku0Hww9pfcOMmv59V89Q zYGZMu6QmQyPmQJVfys6mxXEWu79B55qo6nlgAHJ7fnopNenGyVI1pSb/M6i7q/+SUIozm Pw0edhlS4TZmcXjVNlesnlQVtZsn8QnKq6BzCw1x7ul8oEdMSlB1uIsS2934rA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=BMNiuuDE; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1670840504; a=rsa-sha256; cv=none; b=A2zTmUMdgAjOkPbVAM3RYtVcKGARyxyxCtwsp+t+zjRnWyVEhh231wR8LaYNTscsem40FS ZweE3+9tsczqE3+lE42/7hVnF5IVxPiI/8GEwOb8ch5DObnthwodXXetb083km1CL7V4Hq uSsrOWCqWKWA4AokfTeSReZpig0jlL4MyRQbykcbv4ZSPhHlgLAK8KKplMmjsoKs0wy4jd AzHxsOYEa5JRIdQOHK7TEWYaYTFK+Nmf/8ORrdDrvaD8g80gfKIveJqr9ToLyA6CcBRfaQ SCsJx97WCDm+2OZTe95AdM+jUM4/XvjKPgpx/nfGR44E64nYSskdPj5eLvScwA== X-Migadu-Spam-Score: -5.75 X-Spam-Score: -5.75 X-Migadu-Queue-Id: 4A17F25FDC X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=BMNiuuDE; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net X-TUID: W/sH5IfcI8a+ Tom Gillespie writes: > Got it. Here's the updated patch (I think I did it correctly?). Thanks! You also need a NEWS entry here. > * lisp/ob-core.el (org-confirm-babel-evaluate-cell): Added to control > execution of cells separate from execution of src blocks, it works in > exactly the same way as org-confirm-babel-evaluate. Please quote `symbols' in the commit message and separate sentences with double space. > +;; don't allow this variable to be changed through file settings > +(put 'org-confirm-babel-evaluate-cell 'safe-local-variable (lambda (x) (eq x t))) You can simply use :safe keyword for `defcustom'. I am also wondering if we should include this into bugfix. This is a new feature, but it appears to be important enough to be merged into built-in Org. Bastien, Kyle, any thoughts? -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at