From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id wIb0LbBKTmUwHwAAG6o9tA:P1 (envelope-from ) for ; Fri, 10 Nov 2023 16:22:24 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id wIb0LbBKTmUwHwAAG6o9tA (envelope-from ) for ; Fri, 10 Nov 2023 16:22:24 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0945834B36 for ; Fri, 10 Nov 2023 16:22:23 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=umanitoba.ca header.s=selector2 header.b="h//VxO46"; dmarc=pass (policy=none) header.from=umanitoba.ca; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1699629744; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=+2LufmkP+4qfGTYu+15qKYFEn05tXhiNAvhSKIsuxSs=; b=tcyE5k5SPrbnFoHjdhBlPLbD5GRl2k+ASD76qB5zL5ovuX0zDP1uINWXAzE0EDy6jPxHzw XGJQI4K6fhAQ0tPHZaKX44fwnP3kssA1ByJKVoJ7IBppuNLGjF/jJks+hJKQdgPCE6kYXn pf/8NKwC8jKQavwQYc4JimdD5LtUznomt4jUyCxD5vjTgZNdnW3dxto/Fc3B77de7pvk1U ku2kVhIb0qVqQZTHiR+uNE17ArIffKBr9zWUed9hjyP8pgrk2wbVnSlPM6KVbE7NfPOv1g bulP7Weve2na4PYzZoLjanJjSDb8hvVzhbAqVMC6dcfZCfNv5iDJAjalpMiLEg== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=pass header.d=umanitoba.ca header.s=selector2 header.b="h//VxO46"; dmarc=pass (policy=none) header.from=umanitoba.ca; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=2; s=key1; d=yhetil.org; t=1699629744; a=rsa-sha256; cv=pass; b=LgGgBp0mdeEhsPADhod4hI5P/6iCVAexNlaMW28bFRzzOijeOl0o24EnBur4NYS0rf/vt/ mNReVdsxVqDgc8fPGmiZCZCiPFKlCNYscvabDh9xJQ0338IUAcJp3UZXqdXRfGsMXg+3+W Mip1OFXOYPuYqwJC1y0oUELf3g4Fxq6eNLcW44NCZZmk4kHe11kjQ7hJJfG6em9mIadmdC SXdVb3VdbjAiOhaCOd+ZTQnvKsfOBSRv+dktXAtpxtyBHUfabiCfW8v/72yQZY33DKAzAV LYX0yysxNw6z9MkpYbmJn6vuWwulfkYO+VsIR9GpTnOAoAzAuMDD93xWrTgZ2w== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r1TKB-0003k0-0P; Fri, 10 Nov 2023 10:21:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r1TK9-0003jp-3i for emacs-orgmode@gnu.org; Fri, 10 Nov 2023 10:21:33 -0500 Received: from mail-yqbcan01on2105.outbound.protection.outlook.com ([40.107.116.105] helo=CAN01-YQB-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r1TK5-0000i1-D2 for emacs-orgmode@gnu.org; Fri, 10 Nov 2023 10:21:31 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QJKJDnt0lIQgn5lp7naIDdYDhXM/ANAFJNwaKF/CVbCf7yTrDhhaj4lsmlperFu0Z0QTbUYmc4kCzuRDMeKcuqsPEvIK/y8yUlCpZFr9GoYrvumvOyNvSNKiYptTutd0aZUXZ/Gv3X5S7e1wTloReO5SbPONKPiKZO6Jp4sBvhSkAu1OTwlFGaBvfPdtrMNjRd9ZRYOT7Qi9leecURC/jNTty8+NwEBky3OPGS/sqk027WKVJRE+L01el+9RRS/RLsNjQO3W49BlpmpqYWNXI59wKvzRRzvbXIG0HlhTVglPMPVucogY0RoMR9oUukN6UFLEMJFmB//kD+ZBVEx6mQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+2LufmkP+4qfGTYu+15qKYFEn05tXhiNAvhSKIsuxSs=; b=l/vCBIBV82+eTXXCqenz2ARPc2ZBZtP9CrheIqrLePgwXPjvjembllnhrrLbRKoKnL+AIx9NEAMlBIsHwxf3Nxq9ShRxlkAOeTKWXNRUZb2/Fv+NkoeVXMfcpON+dInKUu3N4Gg10rIoykkh/kHoITL6c/qwYTMKkwi8zWmQFvMQhAC/IpQsge7Q6otSPv4mAbkp6gaEfbrdX+oOmVsY0od2Fz8XQ4HO6qkp2DehUKs5SFkbEY7Y/2vuLGe6FIRef6JVbsoXNVjtdX2dZN08yUWIhjC6N7fYsMPbH8rFx1UaFhMuVROHNslnqtlTth3hQoYTyvDYGYhQUNuqvtAspg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=umanitoba.ca; dmarc=pass action=none header.from=umanitoba.ca; dkim=pass header.d=umanitoba.ca; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umanitoba.ca; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+2LufmkP+4qfGTYu+15qKYFEn05tXhiNAvhSKIsuxSs=; b=h//VxO46X8nKrmZuE7OSb/A1ThcZvluruaB5RzQtjGYsy8OLaRSxJmWDmBetr2POKBCyFX7rXL5j3GQmN0RpCvZAFAw30bd4kVBW2VnbOieQ9YuNHK6oi6sosswRE1wu5HGIu5qwawjeM8mdLhjh0+/qEl9ybTx/phrryPoLpVHY6WssENeHRpazXyhv2Konhd9cMx7E9d4VBKEJUFGhT9MrMQpeOQjnuLvQIHaHdQgJsz3kSisRAajUiYux9+YgyacDFBboiiWjCG7O2JIHsQBmWh3XwktVrKhXKE69IFGuyYNhjVL06C75lz5PI0sRBaZgtsMQRMe3dlYLjZSECQ== Received: from YT3PR01MB9964.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:90::5) by YT1PR01MB9164.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:cf::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6977.19; Fri, 10 Nov 2023 15:21:25 +0000 Received: from YT3PR01MB9964.CANPRD01.PROD.OUTLOOK.COM ([fe80::94c8:d86a:210c:c4d6]) by YT3PR01MB9964.CANPRD01.PROD.OUTLOOK.COM ([fe80::94c8:d86a:210c:c4d6%4]) with mapi id 15.20.6977.018; Fri, 10 Nov 2023 15:21:25 +0000 From: Leo Butler To: Max Nikulin CC: "emacs-orgmode@gnu.org" Subject: Re: [TASK] Allow customizeable ditaa executable in ob-ditaa.el Thread-Topic: [TASK] Allow customizeable ditaa executable in ob-ditaa.el Thread-Index: AQHaErs4BJAyHfs4zESjqByXk5twpg== Date: Fri, 10 Nov 2023 15:21:25 +0000 Message-ID: <874jhtocqz.fsf@t14.reltub.ca> References: <87wmvhnr8b.fsf@t14.reltub.ca> <871qdo5sdh.fsf@web.de> <87y1fwtkth.fsf@localhost> <87sf5f7h04.fsf@t14.reltub.ca> <87zfzmnvl7.fsf@t14.reltub.ca> In-Reply-To: (Max Nikulin's message of "Fri, 10 Nov 2023 17:38:19 +0700") Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Gnus/5.13 (Gnus v5.13) x-ms-publictraffictype: Email x-ms-traffictypediagnostic: YT3PR01MB9964:EE_|YT1PR01MB9164:EE_ x-ms-office365-filtering-correlation-id: 38acec62-9fde-4c6a-0c88-08dbe200b444 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0d0TV+bWXtU8/8Rk1kXuilm7OyBOfkMf6PejyjOqsDsVnO8zqZyUY9cjrZRk895+NGAnZM2vA5n1DyeN243F/Xvvg9cudGj8Sqn5mDdlk1EyuEUUbG2ABtANKMygSjHOpOINof3jZf/as8O+vR/P2hl8fvOywo3K5BnjYdmfdWBXdQ5r6/ADJudMXbsVkWyAhv1NVCD6DrwKinekSWCtJPuVn063mL+MbtvF9UnSGRPswwxOwG6MEsPqCryg/ucUUdqWsC2gEIVpHe361K9N3tUNyG5USIoetsn+Y9L7ZnW6bTATv1U5DDxFmzkMAt73hoCu/j4yeb6hL7AFxg7fPSnmYcS7eGrbFqH9PRTRxhKcRpMzh7hQ/J4gR/lJJKDu4vLn27M7OthTdZ6lYaxcxUoazIcTsVusCukYiPBNTWYOXTFQHGZaWj68roLQbEm2PMQ9wAh3L4xUHbOhUixNbvuI1iamQWKy5csnUYvbSWu4rU5gbIDy17d10Tpci0C4TJGmrECOjewmoSqtbnEScvV30QhwSgLkwBRLW+FiKWxYSTyoTedW7KPyGsCHc4E3UyFAaos7VdiYUscZce1VxjPu4jUS9hQQWc7uB+m24eNbHBfvK9vKe3vlbT+gZWSq x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YT3PR01MB9964.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(396003)(346002)(376002)(366004)(136003)(230922051799003)(451199024)(64100799003)(1800799009)(186009)(66446008)(6512007)(9686003)(478600001)(53546011)(6486002)(6506007)(26005)(71200400001)(64756008)(66476007)(66556008)(83380400001)(66946007)(786003)(6916009)(316002)(76116006)(38100700002)(91956017)(5660300002)(122000001)(8676002)(4326008)(8936002)(41300700001)(86362001)(2906002)(38070700009); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?bHNJqhTF8roLB5fkOXoo/2WRIqDi86Q/ZXtBsuZeaMxIlfBOECqDcgbLkg?= =?iso-8859-1?Q?FB9mLd33fdC4xHVVha+iDR/h2iAosNEqHdNSc/hysSSwXqtnklo3YwosDT?= =?iso-8859-1?Q?Uq/cGB++YYmXd/q49w3AQn7PcwbDWsr35t00Wwz28LNJUIy93Jp3AN/ysb?= =?iso-8859-1?Q?+UqSGvNbvDirhzbSQD0KmVaNG1KluKTFPU6TQDqhGKtGQL33kePIJwg8w8?= =?iso-8859-1?Q?w4z7JJ2CDPwGvXx3hAg31qpxSb/uxtlBqZLvh6whZ47llogvgLa8BHYJx+?= =?iso-8859-1?Q?++S8lGGrtjr3RFaxVxmmq4iLeGNf8joIxPZSxFXI8zzuygfGPbLfKo+7Z0?= =?iso-8859-1?Q?ruj899wSr7KKOpS88mvsllhWr6I1g+yi6eq1STGEyqQvEqRPDaQryPnFap?= =?iso-8859-1?Q?OFntz7RmmHRY6uaId+qZkO0OrY2UxQx787NBc5o41BRkeaKQiKwIcLGVLs?= =?iso-8859-1?Q?igx9RwvhYnqBf6K2QUCTCOZZwVydep/8958Xpr0r2//HJTcCwPAJK1xiSz?= =?iso-8859-1?Q?gYkP9aRzVyeWYyemp+IqoLdSSPq3dadxCWdc83h7ipft5kys7FYvSXa6ui?= =?iso-8859-1?Q?SyEmxUBwxF1cG/4umKnfFyj17IJE7nVpveAM1of6lUhaUubos61aPgQdnM?= =?iso-8859-1?Q?HC0NyxzC6qHSd3b+9g//zfy2UTGjqAeNUBQjuRxXrW2fuIps4LPlLA3o32?= =?iso-8859-1?Q?xvvye7MhnJA34o0w1oOj4FSfmTiwq7dx14gRxot6qOSuTOu9lQQaVo/tXS?= =?iso-8859-1?Q?rbc3EDk2uGiYLFwC7bueVDB131+72coEoBrHpmOs8lVLNpBhV1elVvY1VT?= =?iso-8859-1?Q?JnIlYeHYL+iIKAzd97SJ0ufSuJcESO/iMw2993TVq4vEpmqy8QCyaeoa0T?= =?iso-8859-1?Q?T5xpopSY3YG8tlh8ZAcUW0WAvG+wswMnATFQzMA4ot2vf7KEXHlSgWrEWz?= =?iso-8859-1?Q?dbNJ6dtYx7jwiTrBXFzVwhxp7xNmorvUr50l2+PELA0P0rCUTxeSHZenn/?= =?iso-8859-1?Q?ocSXB2w92Xcn8wdbPnYMHNKOyXy7DTCu8ispxHff8i8JF5Ki45aWlohR4a?= =?iso-8859-1?Q?PTJnPMoeza2IPa2tkoXlGyqyn6z1+4WIFN6Kwkd6U5aT2MlXM3dGNawuyt?= =?iso-8859-1?Q?j7svxncaHXCpfepBONudO82ZcfBT++Wap9AWUfXFv51RBo6ODUU5hiTAUP?= =?iso-8859-1?Q?v+OzJ/UeWbhTERV/beXCqyeQYR2X6ZTzqrbFJ0KcfTfQhWhrGOvURhqQXv?= =?iso-8859-1?Q?l+OuaTn6clVvhJHpY/jooOzAS1RQbHRLLG+T2QJJMQ1PjqAtbMCMQTqZcT?= =?iso-8859-1?Q?B4+rHBkDUWOjITuTbRTOrpWhOQHYeKOCyxOVERz/mWbOARvl2//FKQq8MP?= =?iso-8859-1?Q?B9SQAYBTFSc1ElNJ8NOrZJA6XZc5BJNtL0wDgxYzWZcb46pUmGEc9kdCK0?= =?iso-8859-1?Q?zODbeWiQGK1Ce43Uh8slXR8KMdwvQhCkW0BdzqC1GQ5T5vsff7iiUa17LF?= =?iso-8859-1?Q?Mf0ga2j9LqUhO02mrgZzc93swnd/rWgOkxW369SzrVkPZMeC/EoLloRQIl?= =?iso-8859-1?Q?as1mcanDkIDR2dTmw5Ke/s/WsNg/9OyBiw7VBK4qRHMS41MODz2L0EOF9h?= =?iso-8859-1?Q?6Cx/0wAYWR2Zm6QIRhFKKBFz7FZancM/XgdauVivnjVJpIEjs/1dA/BA?= =?iso-8859-1?Q?=3D=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: umanitoba.ca X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: YT3PR01MB9964.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 38acec62-9fde-4c6a-0c88-08dbe200b444 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Nov 2023 15:21:25.5230 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4f80dd0b-338c-4e4c-8a14-90446962f7b8 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: VN/Ntg2yt3cYsB+yIHmVnAXpZrr7Y1+mXLWO22qq1VagCk8DWpWgJaDMQJ8XOdK+AP+/Qm9XBmMa/jZqlVaPVQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT1PR01MB9164 Received-SPF: pass client-ip=40.107.116.105; envelope-from=Leo.Butler@umanitoba.ca; helo=CAN01-YQB-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -11.55 X-Spam-Score: -11.55 X-Migadu-Queue-Id: 0945834B36 X-Migadu-Scanner: mx10.migadu.com X-TUID: yzCpOMIcmzMr On Fri, Nov 10 2023, Max Nikulin wrote: > On 10/11/2023 10:19, Leo Butler wrote: >> On Thu, Nov 09 2023, Max Nikulin wrote: >>=20 >>> diff --git a/lisp/ob-ditaa.el b/lisp/ob-ditaa.el > [...] >>> should allow to set :java to >>> >>> flatpak-spawn --host toolbox run /usr/bin/ditaa >>> >>> without abusing of org-ditaa-jar-path. Untested. >>=20 >> Doesn't this abuse the `java' header argument, which is intended to pass >> arguments to the java runtime? > > or `org-babel-ditaa-java-cmd'. My point is that requirement of non-empty= =20 > `org-ditaa-jar-path' confused Florin to the degree when workarounds=20 > looked impossible. Notice that setting > > org-ditaa-jar-path "/usr/bin/ditaa" > > still requires spreading of "flatpack-spawn ..." over=20 > `org-babel-ditaa-java-cmd', :java, and `org-ditaa-jar-option'.=20 > fortunately some of these options may be sent empty and other will not=20 > quote spaces, etc. Whole "flatpack-spawn ... ditaa" command can not be=20 > put to `org-ditaa-jar-path' Hi Max, Let me back up for a second: I wrote in the documentation patch "Users may need to use a script to run ditaa." That is a very circumspect statement. That is not saying that we can throw any command at ob-ditaa and it will work. > >> I think that it would be best to implement the change to mirror that >> done in ob-plantuml, as Ihor suggested earlier. > > Agree. I appreciate consistency in treatment of similar cases. I am glad we agree. Now let me tell you my dilemma: a while ago, I suggested a patch to implement similar functionality for ob-maxima. The patch used customization variables, much like ob-plantuml does. Ihor's feedback was that this was not a good approach (too much room for accidental breakage, etc.). Eventually, the patch was amended to acheive the same goals using new header arguments. So, now, in my opinion, consistency would dictate that we re-visit the changes made to ob-plantuml, re-fashion them and do something similar with ob-ditaa. Except, users have likely become accustomed to using ob-plantuml as it is... Thoughts? > > I am not sure in the following idea. Perhaps a concept of "launcher" (or= =20 > "runner") may be introduced. Launchers may be stacked. So for a jar file= =20 > launcher is "java @:java -jar" that may be combined with "toolbox run"=20 > and "flatpak-spawn --host" launchers. > >> My reading of the documentation and ob-plantuml.el is that it is not >> possible to use the `java' header argument in the way you propose for >> ob-ditaa.el. > > Since nobody has proposed a patch for ob-ditaa, I decided that making a=20 > workaround easier is an improvement. I am not in favour of a band-aid, it will hand-cuff us in the future. I explained above why I haven't proposed a patch to ob-ditaa, yet. Best, Leo