From: Karthik Chikmagalur <karthikchikmagalur@gmail.com>
To: "Björn Bidar" <bjorn.bidar@thaodan.de>, emacs-orgmode@gnu.org
Subject: Re: Link preview generation with new link preview property
Date: Thu, 12 Dec 2024 21:49:45 -0800 [thread overview]
Message-ID: <874j382kue.fsf@gmail.com> (raw)
In-Reply-To: <6755f138.0c0a0220.40388.51fbSMTPIN_ADDED_BROKEN@mx.google.com>
> The PR do port the package to this new handler property:
> https://github.com/gaoDean/org-remoteimg/pull/4
>
> However it left me with a few questions:
> - Who is supposed to take care of the scaling/width of the preview
> image, the handler or the caller of the handler?
The handler is responsible for sizing the image. The reason for this is
that the preview does not have to be an image -- it can be any kind of
overlay decoration.
If you decide to use an image file as the preview, you can call
`org-link-preview-file' inside your handler to handle the geometry for
you. This includes the size and alignment specified by #+attr_*
keywords, `org-image-max-width' and `org-image-align'.
If you are using a preview image from image data, you'll have to copy
some of the code in `org-link-preview-file' to your handler if you want
to respect these user options.
> - When calling the link preview function for a description with prefix
> argument 1 I noticed that it doesn't get the contents of the
> description.
> Why is that? In this instance the link looked like this:
> [[https://stable.melpa.org/#/rpm-spec-mode][file:https://stable.melpa.org/packages/rpm-spec-mode-badge.svg]]
I don't follow. What do you mean by "it doesn't get the contents"? Did
the preview work as expected when you used a prefix arg of 1?
Karthik
next parent reply other threads:[~2024-12-13 5:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <6755f138.0c0a0220.40388.51fbSMTPIN_ADDED_BROKEN@mx.google.com>
2024-12-13 5:49 ` Karthik Chikmagalur [this message]
2024-12-14 0:03 ` Link preview generation with new link preview property Björn Bidar
2024-12-14 7:04 ` Ihor Radchenko
2024-12-17 2:46 ` Björn Bidar
2024-12-17 17:39 ` Ihor Radchenko
2024-12-19 21:55 ` Björn Bidar
2024-12-21 12:03 ` Ihor Radchenko
2024-12-17 3:42 ` Karthik Chikmagalur
2024-12-17 17:40 ` Ihor Radchenko
2024-12-19 23:20 ` Björn Bidar
2024-12-20 0:45 ` Karthik Chikmagalur
2024-12-21 12:05 ` Ihor Radchenko
2024-12-18 6:21 ` stardiviner
2024-12-18 6:33 ` Karthik Chikmagalur
2024-12-19 23:26 ` Björn Bidar
2024-12-21 12:09 ` Ihor Radchenko
2024-12-08 19:18 Björn Bidar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874j382kue.fsf@gmail.com \
--to=karthikchikmagalur@gmail.com \
--cc=bjorn.bidar@thaodan.de \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).