* Bug in export to iCal : one solution
@ 2008-06-12 19:23 Paul R
2008-06-13 8:43 ` Carsten Dominik
0 siblings, 1 reply; 2+ messages in thread
From: Paul R @ 2008-06-12 19:23 UTC (permalink / raw)
To: emacs-orgmode
I finaly tracked in down, while sitting in the train. I hope I'll have
enough battery life to give explaination here, and that I'll find some
wireless spot tonight to send this report.
Here is a simplified stack of exporting to ical :
- org-export-icalendar-combine-agenda-files
`- org-export-icalendar
`- org-print-icalendar-entries
`- (org-diary-to-ical-string sexp-buffer) in org-exp.el:3791
A look at org-diary-to-ical-string shows :
,----
| (defun org-diary-to-ical-string (frombuf)
| "Get iCalendar entries from diary entries in buffer FROMBUF.
| This uses the icalendar.el library."
`----
then at the end of this function :
(kill-buffer frombuf)
This line is incriminated. Although I have a very limited
understanding of how the export procedure works, I think it can be
replaced by something like :
(with-current-buffer frombuf (erase-buffer))
or, the "ical-tmp" buffer should be re-created by some mean in the
loop.
I don't understand how it can work for some people, though ... :)
--
Paul
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: Bug in export to iCal : one solution
2008-06-12 19:23 Bug in export to iCal : one solution Paul R
@ 2008-06-13 8:43 ` Carsten Dominik
0 siblings, 0 replies; 2+ messages in thread
From: Carsten Dominik @ 2008-06-13 8:43 UTC (permalink / raw)
To: Paul R; +Cc: emacs-orgmode
On Jun 12, 2008, at 9:23 PM, Paul R wrote:
> I finaly tracked in down, while sitting in the train. I hope I'll have
> enough battery life to give explaination here, and that I'll find some
> wireless spot tonight to send this report.
>
> Here is a simplified stack of exporting to ical :
>
> - org-export-icalendar-combine-agenda-files
> `- org-export-icalendar
> `- org-print-icalendar-entries
> `- (org-diary-to-ical-string sexp-buffer) in org-exp.el:3791
>
> A look at org-diary-to-ical-string shows :
> ,----
> | (defun org-diary-to-ical-string (frombuf)
> | "Get iCalendar entries from diary entries in buffer FROMBUF.
> | This uses the icalendar.el library."
> `----
>
> then at the end of this function :
> (kill-buffer frombuf)
>
> This line is incriminated. Although I have a very limited
> understanding of how the export procedure works, I think it can be
> replaced by something like :
> (with-current-buffer frombuf (erase-buffer))
>
> or, the "ical-tmp" buffer should be re-created by some mean in the
> loop.
>
> I don't understand how it can work for some people, though ... :)
Bummer, you are completely right! The problem is that `org-diary-to-
ical-string' is called in the loop, the call must be outside. Also,
it is not logical to have this function kill the sexp buffer, I have
moved this line out of the function.
Thank you very much for your persistence in tracking down a serious
bug. I am glad you battery lasted long enough... :-)
Fixed now.
- Carsten
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-06-13 8:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-12 19:23 Bug in export to iCal : one solution Paul R
2008-06-13 8:43 ` Carsten Dominik
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).