From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?Q?=C5=81ukasz_Stelmach?= Subject: Re: [PATCH] little fixes for attachment git commiting Date: Fri, 19 Feb 2010 11:59:57 +0100 Message-ID: <873a0xv6c2.fsf@dasa3.iem.pw.edu.pl> References: <87635xuhnd.fsf@dasa3.iem.pw.edu.pl> <0E4FD6B3-1912-4A6B-96A1-0CF00B3EAED1@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NiQaz-0004Oa-AA for emacs-orgmode@gnu.org; Fri, 19 Feb 2010 06:00:29 -0500 Received: from [140.186.70.92] (port=51666 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NiQat-0004Mb-De for emacs-orgmode@gnu.org; Fri, 19 Feb 2010 06:00:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NiQan-0004dk-Ja for emacs-orgmode@gnu.org; Fri, 19 Feb 2010 06:00:20 -0500 Received: from lo.gmane.org ([80.91.229.12]:37473) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NiQan-0004dZ-Dv for emacs-orgmode@gnu.org; Fri, 19 Feb 2010 06:00:17 -0500 Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1NiQak-00055v-P7 for emacs-orgmode@gnu.org; Fri, 19 Feb 2010 12:00:14 +0100 Received: from dasa3.iem.pw.edu.pl ([194.29.147.110]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 19 Feb 2010 12:00:14 +0100 Received: from lukasz.stelmach by dasa3.iem.pw.edu.pl with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 19 Feb 2010 12:00:14 +0100 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Carsten Dominik writes: > On Feb 16, 2010, at 8:04 PM, Łukasz Stelmach wrote: > >> There are two very small commits which iron some wrinkles. Both on >> org-attach-git-commit branch of >> git://github.com/steelman/steelman-org-mode.git >> >> The first prevents git from running on an empty set of deleted files. > > Why is that a problem? I am hesitating to apply this patch, because > on my Mac OS 10.5, xargs does know the --no-run-if-empty argument. ^^^^^^^^^[*] When xargs launches git rm without file arguments git emmits usage --8<---------------cut here---------------start------------->8--- usage: git rm [options] [--] ... -n, --dry-run dry run -q, --quiet be quiet --cached only remove from the index -f, --force override the up-to-date check -r allow recursive removal --ignore-unmatch exit with a zero status even if nothing -matched --8<---------------cut here---------------end--------------->8--- message which in this situation is a bit confusing and *suggests* somehting might have gone wrong. And of course a shell output buffer pops up. [*] does || doesn't? -- Miłego dnia, Łukasz Stelmach