emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Bernt Hansen <bernt@norang.ca>
To: Nathan Neff <nathan.neff@gmail.com>
Cc: emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: Can this function be written better?
Date: Mon, 06 Dec 2010 16:53:36 -0500	[thread overview]
Message-ID: <8739qapnz3.fsf@norang.ca> (raw)
In-Reply-To: <AANLkTimMhnsUme2qAWoXY2cUPdCj_wVVYGjJQW43zuuc@mail.gmail.com> (Nathan Neff's message of "Mon, 6 Dec 2010 12:29:37 -0600")

Nathan Neff <nathan.neff@gmail.com> writes:

> I'd like to be able to easily toggle the showing/hiding of CLOSED clock
> items in the agenda.
>
> I have a function that does exactly that.  My Lisp is terrible (I bet that's
> never been said before :-) and I want to try to improve it.
>
> Any suggestions how to improve/refactor the following function?
>
> (defun njn/agenda-toggle-show-closed()
>   "Toggle whether closed clock thingies are shown in the agenda"
>   (interactive)
>   (if (eq njn/org-agenda-show-closed 't)
>       (progn (setq org-agenda-log-mode-items (quote (clock)))
> 	     (setq njn/org-agenda-show-closed nil)
> 	     (message "NOT Showing closed clock entries in agenda"))
>     (progn (setq org-agenda-log-mode-items (quote (closed clock)))
> 	   (setq njn/org-agenda-show-closed 't)
> 	   (message "Showing closed clock entries in agenda"))
>     ))
>

Hi Nate,

I would probably write it like this: (but I'm no emacs-lisp expert
either)

(defun njn/agenda-toggle-show-closed()
  "Toggle whether closed clock thingies are shown in the agenda"
  (interactive)
  (setq njn/org-agenda-show-closed (not njn/org-agenda-show-closed))
  (setq org-agenda-log-mode-items (if njn/org-agenda-show-closed
				      (quote (closed clock))
				    (quote (clock))))
  (message "%sShowing closed clock entries in agenda" (if njn/org-agenda-show-closed "" "NOT ")))

You have a bug in your version - the test and report is backwards.
When njn/org-agenda-show-closed is t you don't show closed items and
when it's nil you do.

- You don't need to check for equality with 't (and you don't need to
  quote t)
  - everything non-nil is true
  - you can just check that directly in the (if ... )

My version basically does this:
  1. toggle the boolean njn/org-agenda-shot-closed
  2. set org-agenda-log-mode-items based on the boolean
  3. report the value

HTH,
Bernt

next prev parent reply	other threads:[~2010-12-06 21:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-06 18:29 Can this function be written better? Nathan Neff
2010-12-06 21:53 ` Bernt Hansen [this message]
2010-12-07  3:00   ` Nathan Neff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8739qapnz3.fsf@norang.ca \
    --to=bernt@norang.ca \
    --cc=emacs-orgmode@gnu.org \
    --cc=nathan.neff@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).