From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: Faces interaction between org-mode and emacs24 Date: Sun, 19 Aug 2012 17:13:33 +0200 Message-ID: <87393iud7m.fsf@altern.org> References: Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([208.118.235.92]:55704) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T37Bd-0000Ht-6k for emacs-orgmode@gnu.org; Sun, 19 Aug 2012 11:13:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T37Bc-0003WN-7g for emacs-orgmode@gnu.org; Sun, 19 Aug 2012 11:13:09 -0400 Received: from mail-we0-f169.google.com ([74.125.82.169]:46691) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T37Bc-0003WI-1N for emacs-orgmode@gnu.org; Sun, 19 Aug 2012 11:13:08 -0400 Received: by weys10 with SMTP id s10so3916349wey.0 for ; Sun, 19 Aug 2012 08:13:07 -0700 (PDT) In-Reply-To: (Jay McCarthy's message of "Sat, 18 Aug 2012 11:24:58 -0600") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Jay McCarthy Cc: emacs-orgmode@gnu.org Hi Jay, Jay McCarthy writes: > I recently upgraded from emacs23 to emacs24, using the current git > version of org-mode with both (current = e4c4d85). I am now > experiencing something odd. > > If I open up the org-agenda to see my TODOs, the node titles are > colored one way (red for late, gray for future, etc). I have this > color setup using the org-agenda-before-sorting-filter-function > variable, it basically looks at the deadline time and then calls > put-text-property to give the text a new 'face property. You can see > the code here: > > https://github.com/jeapostrophe/exp/blob/master/.emacs.el#L627 (it > goes to about line 736) > > This worked great in emacs23. But now with emacs24, the colors are > only correct when I first start emacs and load the agenda the first > time. If I ever go to visit a TODO item in the org buffer (for > example, by pressing ) then the color of the item from the org > buffer appears in the agenda. For example, if something is one level > deep (*) then it becomes blue-ish, even though my filtering function > has change the face to be red. I assume the above is with column-mode turned on, right? ... > If I put my cursor in the org-buffer on the item and describe its > text-properties, then I get the face to be, for example 'org-level-6, > but if I go to the org-agenda and put my cursor on the text, I see > that the face is 'due (what it is supposed to be) > > Even stranger, if I am in the org-agenda and turn OFF column mode > (org-columns), then I see the "correct" colors of all the items. It is > just in column mode that I see the colors from the org buffer. > > I was able to fix this with the following patch: ... otherwise I don't see why just fixing `org-columns-new-overlay' should fix the first situation you describe. I under the idea behind the patch but I'd like to make sure there is nothing more than this. Perhaps a simple reproducible example? Thanks! -- Bastien