From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bastien <bzg@altern.org>
Subject: Re: bug#12905: 24.2.50; org: edit source block causes data loss
Date: Fri, 14 Dec 2012 10:40:46 +0100
Message-ID: <8738z955up.fsf@bzg.ath.cx>
References: <50A62865.8010904@gmail.com>
	<87sj7han8a.fsf__16482.9143243425$1354894646$gmane$org@gnu.org>
	<87wqwnyzud.fsf__32428.3239235685$1355331429$gmane$org@bzg.ath.cx>
	<87bodzt201.fsf@norang.ca> <877gom7tc3.fsf@bzg.ath.cx>
	<876246skbt.fsf@norang.ca> <87lid262rf.fsf@norang.ca>
	<8738za44ss.fsf@bzg.ath.cx> <878v925aru.fsf@norang.ca>
	<CAM=K+iqz+xCtX1=VKbdAyfFvuj3JPEP=oqnAoY-0U0Kqo6XDag@mail.gmail.com>
	<87wqwm0yoi.fsf@bzg.ath.cx>
	<CAM=K+iq=x557g5VeUFRr4_ZdHznD=KTNGsy1O0JuCGrLZT8eRw@mail.gmail.com>
	<87mwxhyl5l.fsf@bzg.ath.cx>
	<CAM=K+ioHiom-PNz5fV83MtA6JY1pVLG8a8YUvi08MiSUvZbyXw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:54317)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1TjRlE-00051h-3B
	for emacs-orgmode@gnu.org; Fri, 14 Dec 2012 04:40:52 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1TjRlB-00046a-Jm
	for emacs-orgmode@gnu.org; Fri, 14 Dec 2012 04:40:52 -0500
Received: from mail-wi0-f173.google.com ([209.85.212.173]:58818)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1TjRlA-000469-IL
	for emacs-orgmode@gnu.org; Fri, 14 Dec 2012 04:40:49 -0500
Received: by mail-wi0-f173.google.com with SMTP id hn17so298905wib.12
	for <emacs-orgmode@gnu.org>; Fri, 14 Dec 2012 01:40:47 -0800 (PST)
In-Reply-To: <CAM=K+ioHiom-PNz5fV83MtA6JY1pVLG8a8YUvi08MiSUvZbyXw@mail.gmail.com>
	(Le Wang's message of "Fri, 14 Dec 2012 07:40:15 +0800")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Le Wang <l26wang@gmail.com>
Cc: Bernt Hansen <bernt@norang.ca>, emacs-orgmode@gnu.org

> -	    (if (>= end beg) temp
> -	      (goto-char beg)
> -	      (insert "\n")
> -	      (org-edit-src-find-region-and-lang))))
> +	    (if (and beg end)
> +		(if (>= end beg)
> +		    temp
> +		  (goto-char beg)
> +		  (insert "\n")
> +		  (org-edit-src-find-region-and-lang))
> +	      (error "Point not in src block."))))

Note: this is 

  (if (and beg end (>= end beg)) ... ...)

Let's try to optimize such tiny refactoring :)

-- 
 Bastien