From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: test failure Date: Sat, 15 Dec 2012 09:18:58 +0100 Message-ID: <8738z7iv7x.fsf@bzg.ath.cx> References: <6097.1355553446@alphaville> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([208.118.235.92]:44460) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TjmxZ-0004AJ-Kp for emacs-orgmode@gnu.org; Sat, 15 Dec 2012 03:19:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TjmxY-0006pw-C4 for emacs-orgmode@gnu.org; Sat, 15 Dec 2012 03:19:01 -0500 Received: from mail-wg0-f51.google.com ([74.125.82.51]:37352) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TjmxY-0006pi-2r for emacs-orgmode@gnu.org; Sat, 15 Dec 2012 03:19:00 -0500 Received: by mail-wg0-f51.google.com with SMTP id gg4so1777627wgb.30 for ; Sat, 15 Dec 2012 00:18:59 -0800 (PST) In-Reply-To: <6097.1355553446@alphaville> (Nick Dokos's message of "Sat, 15 Dec 2012 01:37:26 -0500") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: nicholas.dokos@hp.com Cc: emacs-orgmode@gnu.org Hi Nick, Nick Dokos writes: > ``make test'' fails on just-updated org: > > Org-mode version 7.9.2 (release_7.9.2-725-ge55681 @ /home/nick/elisp/org-mode/lisp/) > > with the following backtrace: > > ,---- > | Test test-org-src/blank-line-block backtrace: Fixed, thanks. > I thought Michael Brand's problem described in > > http://thread.gmane.org/gmane.emacs.orgmode/63523 > > might have something to do with it, but wrapping a progn around the > forms of the test did not make any difference. > > When I simulate the test by hand, I don't get the error, so this seems > to be another of those errors that only surface when the test suite is > run in batch mode. Indeed. Actually, the test passed okay when trying to edit from line 2 (#+begin_src) so I changed that, since we really want to test whether those source blocks can be edited at all. > BTW, why in the above is the following a prog1, rather than a progn? > > (prog1 (goto-line 3) (org-edit-special) (insert "blah") (org-edit-sr No reason, this is an error. (prog1 ,@body (kill-buffer)) in org-test-with-temp-text-in-file had two problems: (1) (prog1 ,@body ...) is unpredictible (2) (kill-buffer) within (with-temp-buffer ...) does not make sense. I fixed this. Thanks, -- Bastien