From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bastien <bzg@altern.org>
Subject: Re: Dramatic slowdown in org mode
Date: Wed, 19 Dec 2012 00:26:27 +0100
Message-ID: <8738z3t00s.fsf@bzg.ath.cx>
References: <3B4DC1FE5D065545B318ED9F3C7FD58298F058@DB3PRD0106MB177.eurprd01.prod.exchangelabs.com>
	<87sj73vxr7.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:47925)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1Tl6YT-0002Zp-HS
	for emacs-orgmode@gnu.org; Tue, 18 Dec 2012 18:26:34 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1Tl6YR-0005y1-Uf
	for emacs-orgmode@gnu.org; Tue, 18 Dec 2012 18:26:33 -0500
Received: from mail-we0-f180.google.com ([74.125.82.180]:50698)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1Tl6YR-0005xu-No
	for emacs-orgmode@gnu.org; Tue, 18 Dec 2012 18:26:31 -0500
Received: by mail-we0-f180.google.com with SMTP id t57so620118wey.39
	for <emacs-orgmode@gnu.org>; Tue, 18 Dec 2012 15:26:30 -0800 (PST)
In-Reply-To: <87sj73vxr7.fsf@gmail.com> (=?iso-8859-1?Q?=22Abd=F3?=
	Roig-Maranges"'s message of "Tue, 18 Dec 2012 22:47:08 +0100")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: =?iso-8859-1?Q?Abd=F3?= Roig-Maranges <abdo.roig@gmail.com>
Cc: "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>

Hi Abdó,

Abdó Roig-Maranges <abdo.roig@gmail.com> writes:

> I tracked it back to commit a7afe7d, but haven't had the time to
> investigate it further. On my case the slowdown is not as dramatic as
> Eric's, though.

Thanks for the investigation.

The problem was that org-agenda-skip, which is called many times 
during agenda generation, checks whether the point is in a code
source block.  The new org-in-src-block-p distinguish whether 
we are really within or "at" (which includes the #+begin_src
and #+end_src lines).  org-agenda-skip just needs to check
if we are _within_.  I fixed this.

-- 
 Bastien