From: Eric Schulte <schulte.eric@gmail.com>
To: Achim Gratz <Stromeko@nexgo.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] ob-fortran.el, add matrix as input
Date: Thu, 06 Jun 2013 10:17:43 -0600 [thread overview]
Message-ID: <8738sv6wns.fsf@gmail.com> (raw)
In-Reply-To: <8761xs1ecu.fsf@Rainer.invalid> (Achim Gratz's message of "Wed, 05 Jun 2013 22:39:45 +0200")
Achim Gratz <Stromeko@nexgo.de> writes:
> Eric Schulte writes:
>> Applied, Thanks!
>>
>> Litvinov Sergey <slitvinov@gmail.com> writes:
>>
>>> I would like to propose a tiny patch which adds matrix as an input for
>>> ob-fortran.el. See changes in testing/examples/ob-fortran-test.org for
>>> the examples.
>
> I've not had time to test with anything, but this patch seems to make
> the same faulty assumption about tables always being a list of lists
> that I fixed just a few days ago someplace else. When dealing with
> tables you have to expect hlines in place of a list with the row values
> otherwise you will not correctly recognize them.
>
Agreed, I've just updated the matrix check in ob-fortran to be more
strict so that tables with hlines will not be treated as matrices.
A more sophisticated solution to correctly interpret hlines in a manner
acceptable to Fortran would require more Fortran knowledge than I
posses.
Best,
>
>
> Regards,
> Achim.
--
Eric Schulte
http://cs.unm.edu/~eschulte
prev parent reply other threads:[~2013-06-06 16:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-01 17:28 [PATCH] ob-fortran.el, add matrix as input Litvinov Sergey
2013-06-04 4:56 ` Eric Schulte
2013-06-05 20:39 ` Achim Gratz
2013-06-06 16:17 ` Eric Schulte [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8738sv6wns.fsf@gmail.com \
--to=schulte.eric@gmail.com \
--cc=Stromeko@nexgo.de \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).