emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <n.goaziou@gmail.com>
To: Joost Diepenmaat <joost@zeekat.nl>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fix org-indent-region's BEGIN_SRC / END_SRC indentation
Date: Mon, 28 Oct 2013 09:57:20 +0100	[thread overview]
Message-ID: <8738nlbwnj.fsf@gmail.com> (raw)
In-Reply-To: <CAPfy-c1gpggPNENWy2Vv9OT7UTDSCw0rvRrt+2kCYauHXdsaxA@mail.gmail.com> (Joost Diepenmaat's message of "Mon, 28 Oct 2013 09:23:36 +0100")

Hello,

Joost Diepenmaat <joost@zeekat.nl> writes:

> Attached is a 2 character patch that makes org-indent-region indent
> #+BEGIN_SRC and #+END_SRC lines according to org document rules instead of
> the indentation rules of the language /inside/ the source block.
>
> This is my first patch proposal for org-mode, so please let me know if I
> need to modify things. In any case, feedback is welcome!

[...]

> From 659a071cc519ebdaabd586132f1d4d3159475c8d Mon Sep 17 00:00:00 2001
> From: Joost Diepenmaat <joost@zeekat.nl>
> Date: Fri, 25 Oct 2013 11:08:46 +0200
> Subject: [PATCH] Correctly indent BEGIN_SRC and END_SRC lines

Here, you need to specifying what functions and variables are modified
by your patch and how. Something like the following should do:

* lisp/org.el (org-indent-region): BEGIN_SRC and END_SRC lines should
  not be considered part of the source block for the purposes of
  indentation.

> TINYCHANGE

Otherwise, the patch looks good. So I applied it with said
modifications.

Thank you.


Regards,

-- 
Nicolas Goaziou

  reply	other threads:[~2013-10-28  8:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-28  8:23 [PATCH] Fix org-indent-region's BEGIN_SRC / END_SRC indentation Joost Diepenmaat
2013-10-28  8:57 ` Nicolas Goaziou [this message]
2013-10-28  9:51   ` Joost Diepenmaat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8738nlbwnj.fsf@gmail.com \
    --to=n.goaziou@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=joost@zeekat.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).