From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [PATCH] `org-macro--collect-macros' can collect macro definitions from include files Date: Wed, 05 Feb 2014 17:27:38 +0100 Message-ID: <8738jx34p1.fsf@gmail.com> References: <86ob2la6e6.fsf@somewhere.org> <87d2j1y1mw.fsf@bzg.ath.cx> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50281) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WB5KB-0002CF-BW for emacs-orgmode@gnu.org; Wed, 05 Feb 2014 11:27:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WB5K4-0000Ld-Oo for emacs-orgmode@gnu.org; Wed, 05 Feb 2014 11:27:43 -0500 Received: from plane.gmane.org ([80.91.229.3]:55085) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WB5K4-0000LX-HX for emacs-orgmode@gnu.org; Wed, 05 Feb 2014 11:27:36 -0500 Received: from public by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1WB5K3-0005CT-BR for emacs-orgmode@gnu.org; Wed, 05 Feb 2014 17:27:35 +0100 In-Reply-To: <87d2j1y1mw.fsf@bzg.ath.cx> (Bastien's message of "Wed, 05 Feb 2014 17:17:59 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bastien Cc: public-emacs-orgmode-mXXj517/zsQ@plane.gmane.org, Fabrice Niessen Hello, Bastien writes: > "Fabrice Niessen" > writes: > >> As the DOCSTRING of the function `org-macro--collect-macros' tells it, >> it "collects macro definitions in current buffer and setup files", not >> from INCLUDE files. > > Then your patch should change the docstring too. > > I think we want to collect macros from setupfile only, > that's one of the differences between INCLUDE and SETUPFILE. I agree. Not all "Include" files are Org files. Moreover, "INCLUDE" keywords are expanded before initializing macro templates during export, so "MACRO" keywords should be read when appropriate. Regards, -- Nicolas Goaziou