From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: emacs-orgmode@gnu.org
Subject: Re: [RFC] Rewrite indentation functions
Date: Sat, 03 May 2014 16:47:40 +0800 [thread overview]
Message-ID: <8738grw8nn.fsf@ericabrahamsen.net> (raw)
In-Reply-To: 87oazffgne.fsf@ericabrahamsen.net
Eric Abrahamsen <eric@ericabrahamsen.net> writes:
> Nicolas Goaziou <n.goaziou@gmail.com> writes:
>
>> Hello,
>>
>> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>>
>>> Wish I was competent to actually review this, but... In lieu of that,
>>> I'd be happy to run it and report errors. If you think a separate
>>> testing branch is warranted, that might be an idea. Otherwise I'd say
>>> let it drop and we'll pick up the pieces :)
>>
>> You can create a local branch in your git repo and apply the patches
>> I sent (be sure to use the second version of the first patch) there.
>>
>> I can certainly wait for your feedback. If it turns out to be mostly
>> good and no one objects, I will then apply the patches and fix the
>> remnant issues on master branch.
>
> Hi Nicolas,
>
> Right now I'm seeing breakage with `org-set-property' -- this only
> happens on the indentation patches branch. Adding an EXPORT_AUTHOR
> property with that command, value of "asdfadsf", gives me this:
>
> * Test Heading
> :PROPERTIES:
>
> :EXPORT_AUTHOR: asdfasdfnil nil
>
> Extra blank nil, spurious "nils", and no :END:
>
> I'm starting dinner and won't be able to go spelunking right now. I'll
> get to soon, if you aren't seeing this, or don't sort it out first.
>
> Eric
Specifically, in this section of `org-indent-line':
(when (eq type 'node-property)
(let ((column (current-column)))
(save-excursion
(beginning-of-line)
(looking-at org-property-re))
(replace-match (concat (match-string 4)
(format org-property-format
(match-string 1)
(match-string 3)))
t t)
(org-move-to-column column)))
Those match-string calls toward the end both return "nil", and the
"nil"s get inserted directly into the buffer. I tried this with a
minimal setup (load-paths only, and a blank Org file) and could
reproduce.
E
next prev parent reply other threads:[~2014-05-03 8:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-30 13:03 [RFC] Rewrite indentation functions Nicolas Goaziou
2014-04-30 17:08 ` Vikas Rawal
2014-04-30 18:59 ` Sebastien Vauban
2014-05-01 19:11 ` Nicolas Goaziou
2014-05-02 5:38 ` Eric Abrahamsen
2014-05-02 7:32 ` Nicolas Goaziou
2014-05-02 10:01 ` Eric Abrahamsen
2014-05-03 7:47 ` Eric Abrahamsen
2014-05-03 8:47 ` Eric Abrahamsen [this message]
2014-05-03 11:47 ` Nicolas Goaziou
2014-05-04 3:25 ` Eric Abrahamsen
2014-05-04 3:30 ` Eric Abrahamsen
2014-05-04 19:45 ` Nicolas Goaziou
2014-05-04 3:39 ` Eric Abrahamsen
2014-05-05 9:30 ` Nicolas Goaziou
2014-05-06 9:41 ` Bastien
2014-05-07 0:51 ` Eric Abrahamsen
2014-05-07 15:40 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8738grw8nn.fsf@ericabrahamsen.net \
--to=eric@ericabrahamsen.net \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).