From: "Francesco Pizzolante" <fpz-djc/iPCCuDYQheJpep6IedvLeJWuRmrY@public.gmane.org>
To: Bastien <bzg-mXXj517/zsQ@public.gmane.org>
Cc: emacs-orgmode-mXXj517/zsQ@public.gmane.org,
"Stefan-W. Hahn"
<stefan.hahn-T8167Cyi5syzQB+pC5nmwQ@public.gmane.org>,
emacs-devel-mXXj517/zsQ@public.gmane.org
Subject: Re: Fontification of org code block not printed
Date: Fri, 01 Aug 2014 09:31:44 +0200 [thread overview]
Message-ID: <8738dgk6n3.fsf@somewhere.org> (raw)
In-Reply-To: <87lhrdtmyq.fsf-E3UqQZAQFPqWIDz0JBNUog@public.gmane.org> (Bastien's message of "Mon, 28 Jul 2014 18:57:37 +0200")
Hi Bastien,
> This is the fault of Org.
>
> I fixed this in master by removing `org-block-background'.
>
> This is radical but I think this is really better:
> http://orgmode.org/cgit.cgi/org-mode.git/commit/?id=f8b42e8
>
> Sebastien, let's think about another way of getting a
> color for the background, if that's really needed.
I have to say that I'm surprised about the way this issue has been
fixed. Let me tell you why.
1) The fix 'simply' removes a useful Org functionality, which I use for
3 years now, without providing any alternative.
2) The first approach would have been to try to fix the issue instead of
completely removing the functionality which, as I already said, is
present since a long time.
3) A possible workaround, without completely removing
org-block-background, would have been to add a variable in order for
people to activate (or de-activate) it and use it (or avoid the
issue).
4) To conclude, according to Stefan Monnier (see his answser from
2014-07-29 11:38), the issue is due to a bug in ps-def.el and not in
Org:
> It's a problem in the ps-def.el code which handles the `face' property
> in a "naive" way: it fails to merge the various active face properties
> (from the various overlays and the text-property).
Could you, then, put org-block-background back and let the fix be done
in Emacs and not in Org?
Thanks a lot.
Regards,
Francesco
next prev parent reply other threads:[~2014-08-01 7:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-28 16:02 Fontification of org code block not printed Stefan-W. Hahn
2014-07-28 16:57 ` Bastien
2014-07-29 17:07 ` Stefan-W. Hahn
[not found] ` <87lhrdtmyq.fsf-E3UqQZAQFPqWIDz0JBNUog@public.gmane.org>
2014-08-01 7:31 ` Francesco Pizzolante [this message]
2015-05-25 12:22 ` Joe Corneli
2014-07-29 9:38 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8738dgk6n3.fsf@somewhere.org \
--to=fpz-djc/ipccudyqhejpep6iedvlejwurmry@public.gmane.org \
--cc=bzg-mXXj517/zsQ@public.gmane.org \
--cc=emacs-devel-mXXj517/zsQ@public.gmane.org \
--cc=emacs-orgmode-mXXj517/zsQ@public.gmane.org \
--cc=stefan.hahn-T8167Cyi5syzQB+pC5nmwQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).