From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Dima Kogan <dima@secretsauce.net>
Cc: "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>,
Subhan Michael Tindall <SubhanT@familycareinc.org>
Subject: Re: Adding new table rows/cols in a formula update
Date: Wed, 01 Oct 2014 21:38:03 +0200 [thread overview]
Message-ID: <8738b78tt0.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87egusgx72.fsf@secretsauce.net> (Dima Kogan's message of "Tue, 30 Sep 2014 22:44:29 -0700")
Hello,
Dima Kogan <dima@secretsauce.net> writes:
> OK. Patch attached.
Thanks for your patch. Some comments follow.
> From 3b6581c647cb87f0d3e8cee94ce2fb1fb122d3fd Mon Sep 17 00:00:00 2001
> From: Dima Kogan <dima@secretsauce.net>
> Date: Tue, 30 Sep 2014 22:36:21 -0700
> Subject: [PATCH] Field formulas can now add columns as needed
>
> The org-table-formula-make-new-cols customization controls whether and how this
> is done
Your commit message is missing information and "TINYCHANGE" at its end.
See http://orgmode.org/worg/org-contribute.html#sec-5
> +(defcustom org-table-formula-make-new-cols nil
What about `org-table-formula-create-columns'?
> + "Non-nil means that evaluation of a field formula can add new
> +columns if an out-of-bounds field is being set."
First line needs to be complete. E.g.,
"Non-nil means a field formula can create a new column."
> + :group 'org-table-calculation
> + :type '(choice
> + (const :tag "Setting an out-of-bounds field generates an error (default)" nil)
> + (const :tag "Setting an out-of-bounds field silently adds columns as needed" t)
> + (const :tag "Setting an out-of-bounds field adds columns as needed, but issues a warning message" warn)
> + (const :tag "When setting an out-of-bounds field, the user is
> prompted" prompt)))
You need to add :version and :package-version keywords.
> (defgroup org-table-import-export nil
> "Options concerning table import and export in Org-mode."
> :tag "Org Table Import Export"
> @@ -3125,7 +3135,22 @@ known that the table will be realigned a little later anyway."
> (while (setq eq (pop eqlname1))
> (message "Re-applying formula to field: %s" (car eq))
> (org-goto-line (nth 1 eq))
> - (org-table-goto-column (nth 2 eq))
> + (let* ((column-target (nth 2 eq))
> + (column-count (progn (end-of-line)
> + (1- (org-table-current-column))))
> + (create-new-column
> + (and (> column-target column-count)
Is this check really necessary? Doesn't `org-table-goto-column' already
figures it out before creating a new column?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2014-10-01 19:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-29 17:45 Adding new table rows/cols in a formula update Dima Kogan
2014-09-30 19:27 ` Dima Kogan
2014-09-30 19:54 ` Subhan Michael Tindall
2014-10-01 5:44 ` Dima Kogan
2014-10-01 19:38 ` Nicolas Goaziou [this message]
2014-10-01 19:38 ` Dima Kogan
2014-10-01 20:17 ` Nick Dokos
2014-10-03 18:07 ` Dima Kogan
2014-10-10 10:05 ` Nicolas Goaziou
2014-10-10 18:17 ` Dima Kogan
2014-10-11 13:09 ` Bastien
2014-10-11 15:14 ` Nicolas Goaziou
2014-10-11 17:02 ` Dima Kogan
2014-10-12 9:18 ` Nicolas Goaziou
2014-10-12 10:08 ` Bastien
2014-10-12 12:06 ` Nicolas Goaziou
2014-10-12 12:20 ` Bastien
2014-10-13 17:14 ` Achim Gratz
2014-12-08 19:50 ` Achim Gratz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8738b78tt0.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=SubhanT@familycareinc.org \
--cc=dima@secretsauce.net \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).