From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kyle Meyer <kyle@kyleam.com>
Subject: Re: refiling with helm
Date: Sun, 01 Mar 2015 11:17:47 -0500
Message-ID: <87385ozo7o.fsf@kmlap.domain.org>
References: <CAOQHXPowzmUR=khJ_+HD=w_n_QYG8MEYpFRGirWHUb=R1YjY7Q@mail.gmail.com>
	<20150301081326.GD22486@pille.home>
	<20150301081840.GE22486@pille.home>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41506)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kyle@kyleam.com>) id 1YS6Uv-00014B-VO
	for emacs-orgmode@gnu.org; Sun, 01 Mar 2015 11:13:42 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kyle@kyleam.com>) id 1YS6Ur-0007TP-La
	for emacs-orgmode@gnu.org; Sun, 01 Mar 2015 11:13:41 -0500
Received: from mail-qa0-f44.google.com ([209.85.216.44]:38671)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kyle@kyleam.com>) id 1YS6Ur-0007Sw-IY
	for emacs-orgmode@gnu.org; Sun, 01 Mar 2015 11:13:37 -0500
Received: by mail-qa0-f44.google.com with SMTP id n8so19575595qaq.3
	for <emacs-orgmode@gnu.org>; Sun, 01 Mar 2015 08:13:36 -0800 (PST)
In-Reply-To: <20150301081840.GE22486@pille.home> (Stefan-W. Hahn's message of
	"Sun, 1 Mar 2015 09:18:40 +0100")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: "Stefan-W. Hahn" <stefan.hahn@s-hahn.de>
Cc: Xebar Saram <zeltakc@gmail.com>, org mode <emacs-orgmode@gnu.org>

"Stefan-W. Hahn" <stefan.hahn@s-hahn.de> wrote:
[...]
> sorry, on addition:
>> #+BEGIN_SRC elisp
>
>   (setq org-completion-use-ido nil
>         org-completion-use-iswitchb nil
>         org-refile-use-outline-path nil
>         org-completion-handler nil)
>
>>   (defun helm-refile-completing-read (orig-func prompt collection &optional predicate require-match
>>                                                 initial-input hist def inherit-input-method)
>>     "Completing function for org-refile"
>>     (helm-completing-read-default-1
>>      prompt collection predicate require-match
>>      initial-input hist def inherit-input-method
>>      "org-refile" nil t)
>>     )
>>
>>   (advice-add 'org-olpath-completing-read :around #'helm-refile-completing-read)
>>
>> #+END_SRC

Are you sure the advice is necessary?  If either
org-refile-use-outline-path (as above) or
org-outline-path-complete-in-steps is nil, it doesn't seem that
org-olpath-completing-read will be called.  The relevant part of
org-refile-get-location (master, f8731ea) is

    (cfunc (if (and org-refile-use-outline-path
                    org-outline-path-complete-in-steps)
               'org-olpath-completing-read
             'org-icompleting-read))

Then, if org-completion-use-ido and org-completion-use-iswitchb are nil,
org-icompleting-read will use completing-read, which helm-mode should be
able to override.

So, given the default values, I think the only setup needed to get
generic helm completion is

    (setq org-outline-path-complete-in-steps nil)

    (require 'helm)
    (require 'helm-config)
    (helm-mode 1)

However, I'm not an experienced helm user, so perhaps others are
noticing issues that I'm not.

--
Kyle