emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Samuel Wales <samologist@gmail.com>
Cc: emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: [bug] canonical context not work in 8.3
Date: Fri, 07 Aug 2015 10:45:59 +0200	[thread overview]
Message-ID: <8737zvfpvc.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CAJcAo8uq89FveQsZ22CBV1QXpsNty+KWbHFgx-CYZLm1AWgR6g@mail.gmail.com> (Samuel Wales's message of "Thu, 6 Aug 2015 18:38:55 -0700")

Samuel Wales <samologist@gmail.com> writes:

> thank you for fixing.
>
> canonical is always what i want, except for occur-tree.
>
> i did profiler-start then went to org file a few times to average out
> the results.  did i use the correct profiler?

You did.
>
>  command-execute                                               60148  99%
>  - call-interactively                                           60148  99%
>   - org-agenda-switch-to                                        59299  98%
>    - org-show-context                                           59299  98%
>     - org-show-set-visibility                                   59299  98%
>      - show-children                                            59170  97%
>       - outline-end-of-subtree                                  35938  59%
>          outline-next-heading                                    9399  15%
>          org-outline-level                                       4047   6%
>       - outline-map-region                                      23168  38%
>        + #<compiled 0xfc19ab>                                    9558  15%
>          outline-next-heading                                    7399  12%
>      + org-up-heading-safe                                        117   0%
>      + org-show-entry                                               4   0%
>      + org-flag-heading                                             4   0%

`show-children' is the culprit.

Could you evaluate the following function and time it again?

  (defun show-children (&optional level)
    (save-excursion
      (org-back-to-heading t)
      (let* ((current-level (funcall outline-level))
             (level (if level (+ (prefix-numeric-value level) current-level)
                      (save-excursion
                        (outline-next-heading)
                        (if (eobp) current-level (funcall outline-level))))))
        (org-map-region
         (lambda ()
           (when (<= (funcall outline-level) level)
             (outline-flag-region (if (bobp) (point) (1- (point)))
                                  (line-end-position)
                                  nil)))
         (point)
         (org-end-of-subtree t t)))))

Thank you.


Regards,

  reply	other threads:[~2015-08-07  8:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-06 23:10 [bug] canonical context not work in 8.3 Samuel Wales
2015-08-07  0:16 ` Nicolas Goaziou
2015-08-07  1:38   ` Samuel Wales
2015-08-07  8:45     ` Nicolas Goaziou [this message]
2015-08-07 20:27       ` Samuel Wales
2015-08-08  8:07         ` Nicolas Goaziou
2015-08-08  9:19           ` Nicolas Goaziou
2015-08-09 18:53             ` Samuel Wales
2015-08-10 11:39               ` Nicolas Goaziou
2015-08-10 18:31                 ` Samuel Wales
2015-08-10 21:39                   ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8737zvfpvc.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=samologist@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).