From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [bug] org-cycle changed behavior in orgstruct-mode
Date: Sun, 30 Aug 2015 09:13:15 +0200
Message-ID: <8737z145bo.fsf@nicolasgoaziou.fr>
References: <87fv3q2lxs.fsf@gmx.us> <878u9ic8sv.fsf@nicolasgoaziou.fr>
	<87zj1y0zst.fsf@gmx.us> <87614l95p7.fsf@nicolasgoaziou.fr>
	<877fodpzn0.fsf@gmx.us>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59251)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1ZVwmD-0003AZ-Kc
	for emacs-orgmode@gnu.org; Sun, 30 Aug 2015 03:11:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1ZVwmC-0000wq-Jj
	for emacs-orgmode@gnu.org; Sun, 30 Aug 2015 03:11:41 -0400
Received: from relay3-d.mail.gandi.net ([2001:4b98:c:538::195]:49251)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1ZVwmC-0000wG-CQ
	for emacs-orgmode@gnu.org; Sun, 30 Aug 2015 03:11:40 -0400
In-Reply-To: <877fodpzn0.fsf@gmx.us> (rasmus@gmx.us's message of "Sat, 29
	Aug 2015 23:12:51 +0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Rasmus <rasmus@gmx.us>
Cc: emacs-orgmode@gnu.org

Rasmus <rasmus@gmx.us> writes:

> I tried to add show-children, and NOT have org-show-children in the setup
> but alas it doesn't change the situation.  But anyway it's called through
> `org-cycle', in my use-case at least.  This in turn rely on at least
> org-cycle-internal-local which in turn uses org-show-children.

Then `org-cycle-internal-local' could use something like:

  (if (derived-mode-p 'org-mode) #'org-show-children #'show-children)

This would require a comment in the code. This is a small leak but as
long as we don't have a clear (non broken) design for orgstruct, I think
we cannot do much.

> So maybe the easiest way to "fix" this is to advice orgstruct to redirect
> call?  Maybe add-function :around... We can rely on nadvice in master,
> right?

Actually, we can't. "nadvice.el" was introduced in 24.4. AFAIK master
still supports release 24.3.

Regards,