From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [PATCH] protocol: allow users to disable warning about old style
 links
Date: Fri, 16 Jun 2017 08:13:25 +0200
Message-ID: <8737b0h33u.fsf@nicolasgoaziou.fr>
References: <8737b2bwg9.fsf@utexas.edu>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37082)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1dLkVd-00010Q-7C
	for emacs-orgmode@gnu.org; Fri, 16 Jun 2017 02:13:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1dLkVc-0007jR-3U
	for emacs-orgmode@gnu.org; Fri, 16 Jun 2017 02:13:29 -0400
Received: from relay4-d.mail.gandi.net ([2001:4b98:c:538::196]:59935)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mail@nicolasgoaziou.fr>)
	id 1dLkVb-0007gf-T9
	for emacs-orgmode@gnu.org; Fri, 16 Jun 2017 02:13:28 -0400
In-Reply-To: <8737b2bwg9.fsf@utexas.edu> (Alex Branham's message of "Wed, 14
	Jun 2017 14:11:34 +0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Alex Branham <branham@utexas.edu>
Cc: emacs-orgmode@gnu.org

Hello,

Alex Branham <branham@utexas.edu> writes:

> This patch allows org mode users to disable the warning issued about
>old org protocol style links. This is important because sometimes (e.g.
>browser extensions), we don=E2=80=99t have easy control over the format
>specified.

Thank you.

Wouldn't it be better to report it upstream as a bug? I don't think
there are many Org protocols applications out there and the conversion
to the new syntax is easy.

> Issuing the warning is annoying because it pops up in a new window.

I think this variable should go in "org-compat.el", so that we can
remove it when we drop old syntax. It also need
proper :version, :package-version and :safe keywords.

Another option is to make it a simple `defvar' and have the warning
message suggesting to set it.

WDYT?

> From 8bfc951308324de8e455128950193c046691f1f8 Mon Sep 17 00:00:00 2001
> From: Alex Branham <branham@utexas.edu>
> Date: Wed, 14 Jun 2017 14:06:18 +0200
> Subject: [PATCH] protocol: allow user to disable warning about old style =
links
>
> ---
>  lisp/org-protocol.el | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/lisp/org-protocol.el b/lisp/org-protocol.el
> index 825435674..2eb1094e9 100644
> --- a/lisp/org-protocol.el
> +++ b/lisp/org-protocol.el
> @@ -271,6 +271,12 @@ This should be a single regexp string."
>    :package-version '(Org . "8.0")
>    :type 'string)
>
> +(defcustom org-protocol-warn-about-old-links t
> +  "If non-nil (the default), issue a warning when org protocol
> +receives old style links."

  When non-nil, warn when Org protocol receives old style link.


Regards,

--=20
Nicolas Goaziou