From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Drew Adams <drew.adams@oracle.com>
Cc: 19914-done@debbugs.gnu.org
Subject: bug#19914: 25.0.50; `org-store-link' invokes function to add to `org-store-link-functions' twice
Date: Fri, 01 Dec 2017 21:58:37 +0100 [thread overview]
Message-ID: <87374uf9mq.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87h8taguav.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Fri, 01 Dec 2017 19:46:48 +0100")
Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
> Hello,
>
> Drew Adams <drew.adams@oracle.com> writes:
>
>>> This means that it will have done its thing TWICE: once just to check
>>> whether it should/could do its thing and another time so that it does
>>> its thing.
>>
>> Also, the doc of `org-store-link-functions' says nothing about the
>> function being called twice. It says only:
>>
>> "Each function should check if it is responsible for creating
>> this link (for example by looking at the major mode).
>> If not, it must exit and return nil.
>> If yes, it should return a non-nil value after a calling
>> `org-store-link-props' with a list of properties and values."
>>
>> (And "a calling" is a typo - it should be "calling".)
>>
>> This doc is essentially a spec telling you what a function for this
>> list should do. From the doc, its purpose is to (a) check whether
>> it should call `org-store-link-props' and (b) if so, call it and
>> return non-nil, else return nil (without calling it).
>>
>> Nothing suggests that the function, if invoked to define a link,
>> will be invoked twice: once for (a) (even though (b) will also be
>> done then) and a second time for (b).
>
> This function no longer invokes twice the function used to create the
> link.
Closing this bug.
prev parent reply other threads:[~2017-12-01 20:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <c8abaaad-c214-4135-bdec-27c41ca3bda9@default>
[not found] ` <99056495-17e4-4cc4-86e7-9e506f2a100c@default>
2017-12-01 18:46 ` bug#19914: 25.0.50; `org-store-link' invokes function to add to `org-store-link-functions' twice Nicolas Goaziou
2017-12-01 20:58 ` Nicolas Goaziou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87374uf9mq.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=19914-done@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).