From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [PATCH v2 0/3] org-sbe fixes Date: Sun, 25 Mar 2018 23:06:54 +0200 Message-ID: <87370namq9.fsf@nicolasgoaziou.fr> References: <87605tc67l.fsf@nicolasgoaziou.fr> <20180319002314.8162-1-git@thecybershadow.net> <87woy7br6q.fsf@nicolasgoaziou.fr> <877epzaolf.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:48568) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f0Cr2-0007z1-CS for emacs-orgmode@gnu.org; Sun, 25 Mar 2018 17:07:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f0Cqv-00028K-6J for emacs-orgmode@gnu.org; Sun, 25 Mar 2018 17:07:04 -0400 Received: from relay0.mail.gandi.net ([217.70.178.220]:47007 helo=relay0-d.mail.gandi.net) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f0Cqv-00027E-01 for emacs-orgmode@gnu.org; Sun, 25 Mar 2018 17:06:57 -0400 In-Reply-To: (Vladimir Panteleev's message of "Sun, 25 Mar 2018 20:40:14 +0000") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Vladimir Panteleev Cc: Alan Schmitt , emacs-orgmode@gnu.org Hello, Vladimir Panteleev writes: > One ugly fix would be to patch over this by checking for some common > lisp forms that result in a list, such as (list ...) and (quote ...), > and treat the remaining ones in a backwards-compatible way. However, > the more time I spend on org-sbe, the more I think that perhaps > a better approach would be to deprecate org-sbe (or outright remove > it, I could argue that due to the overwhelming number of flaws its > mere presence is downright harmful), and replace it with something > more sensible: a function (not macro) defined somewhere other than > ob-table (because it is not specific to tables) without any of the > crazy string escaping logic. > > What do you think? I have reverted your changes from maint. I agree "org-sbe" should be rewritten. However, it is specific to tables because it is meant to be used in a TBLFM line. Its replacement could live in "org-table.el", though. Regards, -- Nicolas Goaziou 0x80A93738